Repository navigation
Move JsxDOM types etc. into @rescript/react(-dom) #8400
Description
Activity
I started to work on it here:
rescript-lang/rescript-react#151
#8282Now, after about 2 months, there are a lot of conflicts. Maybe it's a good starting point. Maybe not. Could fix the merge conflicts first, if this is going in the right direction.
Reacted by Paul TsnobiladzéNot sure. I was originally leaning towards splitting it off to match what people would be expecting following the npm package structure (
react/react-dom,@types/react/@types/react-dom).OTOH maybe keeping it a single package with all features on by default would improve compatibility/ease migration.
You're right, those are separate packages in js so it'd make sense to stick to the same structure.
So, I updated my branches and fixed the conflicts.
Unfortunately, I have no idea how to fix the missing dependencies. Rescript-React should be included in the monorepo since the dependencies point to a "workspace" version?!
Proposal:
Dom,Dom_storage,Dom_storage2from the@rescript/runtimepackageexperimental-webapi@rescript/reactdepend on that@rescript/react-domJsxDOM/JsxDOMStyle/JsxEventinto@rescript/react-domNote that any vendoring here (
@rescript/react,@rescript/react-dom, relevant parts of webapi and rescript-react-native/Xote) does not mean moving the source of truth for these packages into the compiler repo. It's just for easier and quicker iteration while moving things around.Once the new shape has crystallized, things need to be synced back to the respective repos.