Repository navigation
fix(docs): install @rig-c/core and run the local bins in the walkthrough - #31
Merged
Merged
Conversation
Follow-up of the owner's naming policy (rig-c/rig-c.github.io#109). The rolling install names the canonical @rig-c/core; the version check and the pose clean step use `bun run rigc` / `bun run rig-pose` instead of `bunx`, which can fall back to fetching an unrelated npm package when the local bin is not what it resolves. Same flags, same steps, the guide's voice unchanged. Measured (offline local-bin fixture): both `rigc` bin candidates — the scoped package and the transitive `rig-c` that parts and pose still depend on — print 2.79.0; the pose clean step writes 73 frames; the guide's own parser keeps 12 steps and 27 local links resolve. Not measured: a fresh rolling install's bin selection, which CI's walkthrough answers. Refs #30 Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30. README lines 51, 54, 186: install
@rig-c/core(canonical) instead ofrig-c;bun run rigc --versionandbun run rig-pose clean …instead ofbunx, so the installed local bins are what runs. Prose and every other byte unchanged.Both
rigcbin candidates (scoped core and the transitiverig-cparts/pose depend on) print 2.79.0 in an offline fixture; a fresh install's bin selection is what this PR's walkthrough CI answers.🤖 Generated with Claude Code