Repository navigation
fix(head-turn): rebuild with parts 1.71.1 and play 1.21.0, and give the page its own physics world - #106
Merged
Conversation
…he page its own physics world The live demo's front hair tore while the head turned (#104). Two causes were in @rig-c/parts and are released in 1.71.1 (#792: a unit part attached as a mesh gets its own carrier and the turn's parallax; #794: no fringe push-back or seam-colour bake between parts the turn moves apart). The third was the page: it played under the runtime's default wind [1, 0]. The page now sets its own world, wind [0, 0] and gravity [0, 1], and the rig is rebuilt from published versions only (parts 1.71.1, play 1.21.0; the rest as pinned in package-manifest.json), re-running assemble so the moving-pair fix applies. Measured on the remote pool (rigc render, hair_front | face seam, world-grid cells, worst frame each, before = the deployed bundle): - turn (31 frames): gap 1400 -> 150, ghost 7497 -> 1840 - tilt (25 frames): gap 861 -> 1, ghost 5115 -> 498 - 0 folded meshes before and after A residual stepped edge at the bang tips remains, strongest at pitch +/-12; this is an improvement, not a zero-seam claim, and the residual is its own follow-up. Also: clean install of the manifest's exact versions rebuilds all 11 bundle files byte-identically; sign and order, slider limits, no rigid 2D spin and the page's physics world hold; site build, verify, links and 72 tests pass. DPR 2 frame callback p50/p99 0.40 / 1.20-1.30 ms on the pool's software WebGL (SwiftShader) — no hardware claim. Closes #105 Closes #104 Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #105, closes #104. Rebuilt from parts 1.71.1 + play 1.21.0 (published only), assemble re-run so the moving-pair fix applies, and the page sets its own physics world (wind 0).
Fine streak tearing at the bang tips is gone in the full-size before/after crops; a stepped edge remains at pitch ±12 — improvement, not zero seam; follow-up filed separately. Clean install rebuilds all 11 bundle files byte-identically; sign/order, slider limits, no 2D spin, physics world, site build/verify/links and 72 tests pass.
🤖 Generated with Claude Code