Repository navigation
feat(demo): rebuild the head-turn demo on parts 1.75.0, with an independent neck, matched ears and yielded inpaint - #114
Merged
Conversation
…endent neck, matched ears and yielded inpaint The head-turn demo showed three defects in motion. - A tear and a baked collar line in the neck. The neck came from the head-run cut, which carries garment collar pixels. It is now assembled from the full run (`["neck", "full", "neck"]`) as its own body-group unit: a `neck_part` bone under `chest`, one rigid segment, and `turn.body.unitDepths.neck` 31.7338. Body yaw carries it independently of the head. - Ears that moved unequally. Their implicit depths were sampled where the face art is transparent: 16.06 px of yaw travel on one side, 5.35 on the other. Equal explicit `turn.unitDepths` (-7.0432) make both travel the same. - A grey patch in front of the neck. It is See-through's inpainted inner collar, kept on topwear where the painting shows neck skin. `assemble.yield_refused: true` (parts 1.75.0) yields those drift-refused pixels to the neck behind. The large patch is gone; a fine stippled trace a few pixels long remains at native scale. Before the eye-check, every animation (body_turn, clip, gaze_x, gaze_y, idle, roll, tilt, turn) was rendered at setup, min, max and |max−min| at native scale. Each touched boundary was cropped native and 4× and labelled. No open tear was found, and the neck/collar is labelled ghost for the remaining trace. The owner approved the rebuilt preview. Verification: targeted 12/0, full 75/0, build 14 pages / 8 redirects, verify 14 HTML / 14 Markdown / 8 redirects, 0 broken links, and a fresh clean rebuild byte-identical 11/11. core 2.79.0 and play 1.21.0 are unchanged. No art was edited and no cut was added. Closes #112 Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Contributor
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112.
This rebuilds the head-turn demo on
@rig-c/parts@1.75.0to fix three defects in motion:unitDepths.neck31.7338)turn.unitDepths(-7.0432) for both earsassemble.yield_refused: true(parts#821); the large patch is gone, and a fine trace a few pixels long remainsBefore the eye-check, each of the 8 animations was rendered at setup, min, max and
|max−min|at native scale. Every touched boundary was cropped native and 4×, and each crop was labelled. No open tear was found. The neck/collar is labelled ghost for the remaining trace. The owner approved the rebuilt preview.core 2.79.0 and play 1.21.0 are unchanged. No art was edited and no cut was added.
🤖 Generated with Claude Code