Repository navigation
ci: retire lockfile.yml in favour of Renovate lockfile maintenance - #21
Conversation
Renovate already does this job: default.json enables lockFileMaintenance (quarterly), the Dependency Dashboard's "Awaiting Schedule" checkbox runs it on demand, and the pull request it opens runs node-ci, whose frozen install and build are the same proof lockfile.yml ran. Renovate does not run package manager scripts by default, so the write-token isolation lockfile.yml needed two jobs, an artifact and a hash check for does not arise. Nothing calls it: a sweep of every non-fork, non-archived repository on the account and in TanksterAI found no caller of rishitank/.github/.github/workflows/lockfile.yml. The two lockfile callers that exist (quarterdeck, tankster-ai-public) use TanksterAI/.github's copy. CONTRIBUTING now points at the dashboard checkbox, and for a package.json change on one's own branch, at a local install. The README drops the table row and the runner-selection exception for the commit job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QQznJLVxB676WmdjNc4D2F
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
|
@coderabbitai review Generated by Claude Code |
✅ Action performedReview finished.
|
What changed
Deletes the reusable
lockfile.ymlworkflow. CONTRIBUTING's Dependencies section now says to regenerate a lockfile by ticking lock file maintenance under "Awaiting Schedule" on the repo's Dependency Dashboard; for apackage.jsonchange on your own branch, run the package manager's install locally. The README drops the workflow's table row and the runner-selection exception for itscommitjob, and notes the dashboard checkbox next to "Lockfile maintenance is quarterly".Why
Renovate already does this job, with less code and a smaller attack surface:
default.jsonenableslockFileMaintenance, which deletes the lockfile, re-resolves and opens a PR. The dashboard's "Awaiting Schedule" checkbox runs it on demand (checked in Renovate'sdependency-dashboard.ts).node-ci.yml, whosenpm ci/pnpm install --frozen-lockfileand build are the same prooflockfile.ymlran.ignoreScripts). So the write-token isolation that tooklockfile.ymltwo jobs, an artifact and a hash check doesn't arise.Nothing calls it. I checked every non-fork, non-archived repository on
rishitankandTanksterAI(72 in all) and found no caller ofrishitank/.github/.github/workflows/lockfile.yml. The only lockfile callers,TanksterAI/quarterdeckandTanksterAI/tankster-ai-public, useTanksterAI/.github's own copy, which this PR doesn't touch.Callers reference these workflows at
@v1, so the file stays available there untilv1is moved withmove-major-tag.yml. With no callers, moving it breaks nothing.How it was verified
actionlint: clean.tests/reconcile/test.sh: 60 passed, 0 failed.tests/auto-merge-sweep/test.sh: 25 passed, 0 failed.git grep lockfile.yml: no references left.Caller sweep: sparse-cloned
.github/and the Markdown files of all 72 repositories and grepped forworkflows/lockfile.yml. Two hits, bothTanksterAI/.github/...@v1.The repo's quality gate passes locally
New behaviour has a test that fails without the change (n/a: removal only)
Risk
If a caller I couldn't see exists (for example a repository outside these two owners), it keeps working until
v1moves past this commit, then fails with a missing-workflow error on its next manual run. It would be aworkflow_dispatchrun, so nothing breaks unattended.Generated by Claude Code