Repository navigation
Conversation
It enabled auto-merge on every same-repo PR, not just Dependabot's. Renovate enables platform automerge on its own PRs via the shared preset, and release.yml already enables auto-merge on the release PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0171XyyqTUH64gAi1AcerwjN
Version updates move to Renovate. Dependabot alerts stay on; Renovate's vulnerabilityAlerts reads them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0171XyyqTUH64gAi1AcerwjN
…elease runs - renovate.json now extends github>rishitank/.github:node (replaces the stale config:base setup that referenced packages holocron no longer uses) - repo-specific rules: group vitest majors; cap typescript below 6.1.0 until typescript-eslint widens its peer range - release.yml: add workflow_dispatch so the release PR can be refreshed by hand; the release job only runs on refs/heads/main Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0171XyyqTUH64gAi1AcerwjN
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request removes the Dependabot configuration and auto-merge workflow, updates Renovate settings, and adds a manual trigger to the release workflow with a main-branch guard. ChangesDependency update configuration
Pull-request auto-merge
Release workflow
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Other Merge Risk: ⚪ Minimal · up to The automation changes are bounded: release processing remains limited to main, while dependency update behavior moves to Renovate. No actionable merge risk is established. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The main-branch gate and existing release-job dependency limit the new manual trigger. The change nevertheless makes privileged release automation manually reachable, and the effective dispatch, publishing, and shared update-policy controls have not been confirmed. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the release gate, Comment |
|
This answers the two "retained concerns" in the Security Architecture Review of f6c93ea, point by point. Neither needs a code change. 1. Manual dispatch reaches the release path.
2. Update policy lives in a shared preset. The preset is public,
No change made. |
What
renovate.jsonnow extends the shared presetgithub>rishitank/.github:node, which in turn extendsgithub>rishitank/.github(default.json). The old file usedconfig:baseand listed packages holocron no longer depends on (@orama/*,tree-sitter*), so it is replaced rather than edited..github/dependabot.ymlis removed. Renovate takes over version updates for npm and GitHub Actions..github/workflows/auto-merge.ymlis removed (reasoning below).release.ymlgetsworkflow_dispatch:, so the release-please PR (currently chore: release 0.1.2 #13, 4 commits behind main) can be refreshed by hand without a push to main. Therelease-pleasejob now hasif: github.ref == 'refs/heads/main', so a dispatch from any other branch does nothing.build-releasedepends on it, so it is skipped too.What the presets do (so nothing is a surprise)
From
default.json:config:recommended,:semanticCommits,:dependencyDashboardandhelpers:pinGitHubActionDigests. Expect a first PR that pinsactions/*@v7and similar tags to SHAs.rangeStrategy: bump.major-upgradelabel and wait for a 7-day release age;vulnerabilityAlerts: security PRs open immediately, with thesecuritylabel and no schedule or release-age wait.From
node.json:.nvmrc) and npm bumps are not automerged; they get theruntime-upgradelabel.typescriptmajor waits 14 days and is not automerged.vitestand@vitest/**minor/patch updates are grouped as "test tooling" and automerged.Repo-specific
packageRules(only where the preset can't know):@vitest/coverage-v8must be on the same major asvitest. Dependabot had an ignore rule for exactly this.typescriptallowedVersions: "<6.1.0".typescript-eslint@8.70.xhas the peer rangetypescript >=4.8.4 <6.1.0. A TypeScript 6.1+/7 PR would failnpm ciwith ERESOLVE. Dependabot ignored TypeScript majors for the same reason. Remove the cap when typescript-eslint widens its range.Dependabot ignore rules I intentionally did not carry over:
zod4.@modelcontextprotocol/sdknow declareszod: ^3.25 || ^4.0, so the stated reason no longer holds.eslint10.Both would be major PRs, and those are never automerged under the preset. They wait on the dependency dashboard for a human.
Why auto-merge.yml is removed rather than rewritten
It ran on every non-draft, same-repo
pull_requestand calledgh pr merge --auto --squash. It had no actor check, so it enabled auto-merge on any PR opened from a branch in this repo, not only Dependabot's. Its actual jobs are now covered elsewhere:automerge: true/automergeType: "pr"uses GitHub platform automerge. Renovate enables auto-merge on its own PRs, gated by the same required checks.release.ymlalready runsgh pr merge --squash --autoon it.So a rewrite would have no remaining job. Behaviour change to note: Dependabot's production-dependency minor/patch PRs used to be auto-merged. Under the preset they are not (only devDependencies and Actions are). That is deliberate.
Dependabot alerts stay on
This PR removes only the Dependabot version-updates config. Dependabot alerts stay enabled. Renovate's
vulnerabilityAlertsreads those alerts through the GitHub API to open its security PRs, so turning alerts off would blind Renovate.Verification
npx renovate-config-validator --strict→Config validated successfully.release.ymlparses as YAML, and the diff is limited to the trigger and the job guard.Risks
What Rishi must do
dependabot.yml, and if it stays on, Dependabot and Renovate will both open PRs for the same advisory.auto-merge.ymlexists on main, it enables auto-merge on any same-repo PR the moment it is marked ready.🤖 Generated with Claude Code
https://claude.ai/code/session_0171XyyqTUH64gAi1AcerwjN
Summary by CodeRabbit
mainbranch.