Repository navigation
chore(deps): update dependency @types/node to v26 - #12
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔦 Lighthouse CI
This repo’s lighthouserc assertions can fail this check. |
rishitank
left a comment
There was a problem hiding this comment.
Self-review by Claude
Checked package.json and bun.lock. The manifest and lockfile agree: @types/node 26.6.4 is locked with undici-types 8.9.0. Typecheck, build and Browser tests are green. The Lighthouse failure is the repo-wide one handled in #11.
Note: these types describe Node 26 APIs, while CI runs on Bun. Typecheck would not catch a Node-26-only API used by mistake. That risk is low for this app. Nothing to fix.
4719a5f to
bb4e0de
Compare
🧪 Runtime gate✅ Runtime crawl: no runtime errors1 page(s) opened in a real browser (desktop + phone), safe controls exercised, forms tried with dummy data, links followed client-side, missing-route probe run. 14s. Coverage: 1/1 routes · 2/3 controls operated · 1/1 forms submitted · 39.3% of the app's own JavaScript executed Against the default branch: routes ±0, controls ±0, JS ±0 pts. No visual changes against the last default-branch run. Pages visited
AI explorer not run: no major/framework signal in this PR. Add the Screenshots, diffs and the app log: runtime-gate artifact. |
Independent Claude review (cloud session)Head reviewed: Recommendation: MERGE (low risk), with one non-blocking note. Merging is the owner's call; I have not approved or merged anything. What changed
Verification (fresh checkout of the head,
|
| Step | Result |
|---|---|
| lint | pass (0 errors) |
| typecheck | pass |
| test | pass (8 files, 264 tests) |
| build | pass |
merged onto current main (7e5977f) |
install, lint, typecheck, test and build all pass |
| merged together with #13 | no conflicts |
Local runs used Node v22.22.0 (the repo's .nvmrc is 22) and Bun 1.4.2. CI pins Bun 1.3.13, so the frozen-lockfile check passing here is supporting evidence, not identical to CI. E2E and Lighthouse were not re-run locally; I relied on CI for those.
Findings (ranked)
- Low, non-blocking: types target Node 26, the repo targets Node 22.
.nvmrcis22and Lighthouse CI runs Node from.nvmrc.@types/node26 therefore declares APIs that don't exist at runtime. A mistaken use of a Node-26-only API would typecheck and then fail at runtime. Current exposure is tiny: the only Node imports arenode:fs,node:pathandnode:url(src/lib/tokens.test.ts,vitest.config.ts), which are identical in 22 and 26.tsconfig.jsonsets"types": ["vite/client"], so Node globals are not ambient in app code. Suggested follow-up, not for this PR: either keep@types/nodeon the major matching.nvmrc(a RenovateallowedVersionsrule), or bump.nvmrcand CI to a Node 26 line together. - Info: branch is 5 commits behind
main.mainhas moved (vite 8.3.3, eslint-plugin-react-refresh, etc.). GitHub reports it clean and I verified the merge result passes, so no action is needed. - Info: no changelog.
@types/nodehas no release notes; I found no breaking-change notes to check.undici-types8.9.0 is a types-only transitive dependency.
Fixes
None needed, so no commits were pushed to this branch.
Gate status
- CI on this head: green. Lint/typecheck/test/build, Browser tests, Lighthouse CI, Runtime gate, Vulnerable dependencies and Secrets all pass.
security / Ecosystem auditandflowsare skipped, as in the workflow config. - CodeRabbit: skipped. It posted "Review skipped: Bot user detected" on this PR. I did not trigger it, per instructions. Whether that satisfies "checked on the head" is the owner's call.
- Unresolved threads: none (0 review threads).
- Caveat: Renovate may recreate this branch, which would change the head SHA and make this review stale.
Generated by Claude Code
This PR contains the following updates:
^22.16.5→^26.6.4Configuration
📅 Schedule: (in timezone Europe/London)
* 0-6 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.