Skip to content

ci: pin the shared reusable workflows to the v1 commit - #14

Merged
rishitank merged 1 commit into
masterfrom
fix/coderabbit-test-11
Oct 9, 2026
Merged

rishitank merged 1 commit into
masterfrom
fix/coderabbit-test-11

Conversation

@rishitank

Copy link
Copy Markdown
Owner

Why

#11 merged with two CodeRabbit threads still open. Both say the same thing: the three callers of rishitank/.github use the mutable @v1 tag, so a tag move can change the workflow code that runs here without any change in this repository. GitHub recommends a full commit SHA for reusable workflows, and zizmor flags these as unpinned-uses.

That is valid. Pinning does not lose the "pick up shared fixes" benefit of @v1: the house Renovate preset (helpers:pinGitHubActionDigests) keeps the digest current, so a tag move now arrives as a reviewed Renovate PR instead of silently.

What changed

  • .github/workflows/ci.yml: node-ci.yml@v1 becomes node-ci.yml@5c644123ed93759cf78aa32d9d119150910e113e # v1.
  • .github/workflows/security.yml: security.yml@v1, pinned the same way.
  • .github/workflows/workflows-lint.yml: workflows-lint.yml@v1, pinned the same way.

5c644123 is the commit the v1 tag resolves to today, so the code that runs is unchanged. runtime.yml already pins a SHA and is untouched. actionlint is clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_012rYJxu978iUSGFZ1UuqTsi

Follow-up to #11, addressing its two open CodeRabbit threads: ci.yml
(node-ci), security.yml and workflows-lint.yml called
rishitank/.github at the mutable `@v1` tag. Pin all three to
5c644123ed93759cf78aa32d9d119150910e113e, the commit v1 resolves to,
with a `# v1` comment. The house Renovate preset
(helpers:pinGitHubActionDigests) keeps the digest current, so tag moves
still arrive, as reviewed PRs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012rYJxu978iUSGFZ1UuqTsi
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f04d85e4-e4a3-4ffa-8365-d72bec56ebc8
📥 Commits

Reviewing files that changed from the base of the PR and between 60f379f and 5f62745.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • .github/workflows/security.yml
  • .github/workflows/workflows-lint.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: runtime / Runtime gate
  • GitHub Check: security / Vulnerable dependencies
  • GitHub Check: security / Ecosystem audit
  • GitHub Check: test / Check
🔇 Additional comments (3)
.github/workflows/ci.yml (1)

22-22: LGTM!

.github/workflows/security.yml (1)

22-22: LGTM!

.github/workflows/workflows-lint.yml (1)

18-18: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Pinned the shared workflows used for CI, security checks and workflow linting to a specific revision.

Walkthrough

Three GitHub Actions workflows now pin their shared workflow reference to commit 5c644123ed93759cf78aa32d9d119150910e113e instead of the movable v1 tag. The workflow inputs remain unchanged.

Changes

Reusable workflow pinning

Layer / File(s) Summary
Pin shared workflow references
.github/workflows/ci.yml, .github/workflows/security.yml, .github/workflows/workflows-lint.yml
The test, security, and actionlint jobs now reference the shared workflow by commit SHA instead of the v1 tag. Inputs remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 5f627

The workflows remain pinned to the current v1 target with compatible inputs; no actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly describes the main change: pinning shared reusable workflows to the v1 commit.
Description check Passed The description explains why the workflows are pinned, identifies all changed files, and describes the commit and Renovate process.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Apprentice, the workflows hold their course,
A fixed commit marks their source.
CI and security share the pin,
Lint checks follow the same discipline.
The Dark Side keeps the reference still.

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

🧪 Runtime gate

✅ Runtime crawl: no runtime errors

1 page(s) opened in a real browser (desktop + phone), safe controls exercised, forms tried with dummy data, links followed client-side, missing-route probe run. 37s.

Coverage: 1/1 routes · 0/0 controls operated · 0/0 forms submitted · 29.3% of the app's own JavaScript executed

Against the default branch: routes ±0, controls ±0, JS ±0 pts.

No visual changes against the last default-branch run.

Pages visited
Page Status ms Controls operated Forms submitted Problems
/ 200 8976 0/0 0/0 0

AI explorer not run: no major/framework signal in this PR. Add the ai-explore label to request one.

Screenshots, diffs and the app log: runtime-gate artifact.

@rishitank
rishitank merged commit 2a48759 into master Oct 9, 2026
8 checks passed
@rishitank
rishitank deleted the fix/coderabbit-test-11 branch October 11, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant