Repository navigation
fix(core): drop unused runtime dependencies - #2071
Merged
eersnington merged 1 commit intoOct 21, 2026
Merged
Conversation
Core declared @aws-sdk/client-s3, better-sqlite3, minimatch, and zod-to-json-schema but never imports them; S3 and SQLite live in the sidecar and runtime-core owns its zod-to-json-schema dependency. Also drop better-sqlite3 from onlyBuiltDependencies, since no workspace package installs it anymore.
Contributor
📟 Pip-Boy ·
|
| package (linux-x64-gnu) | @latest |
base | this PR | Δ vs base | packages |
|---|---|---|---|---|---|
@rivet-dev/agentos-core |
458.2 MB | 345.2 MB | 325.9 MB | −19.3 MB (−5.6%) | 10 (−67 (−87.0%)) |
@rivet-dev/agentos-sandbox |
495.5 MB | 382.4 MB | 363.5 MB | −18.9 MB (−4.9%) | 85 (−49 (−36.6%)) |
`@rivet-dev/agentos-core` details
| platform | base | this PR | Δ |
|---|---|---|---|
| linux-x64-gnu | 345.2 MB | 325.9 MB | −19.3 MB (−5.6%) |
| linux-arm64-gnu | 342.4 MB | 323.1 MB | −19.3 MB (−5.6%) |
| darwin-arm64 | 321.7 MB | 302.4 MB | −19.3 MB (−6.0%) |
| darwin-x64 | 331.2 MB | 311.9 MB | −19.3 MB (−5.8%) |
| win32-x64 | 201.6 MB | 182.3 MB | −19.3 MB (−9.6%) |
Removed dependencies
| package | size | via |
|---|---|---|
better-sqlite3@12.11.1 |
9.9 MB | @rivet-dev/agentos-core › better-sqlite3 |
@aws-sdk/client-s3@3.1154.0 |
3.2 MB | @rivet-dev/agentos-core › @aws-sdk/client-s3 |
@smithy/core@3.36.1 |
1.9 MB | @rivet-dev/agentos-core › @aws-sdk/client-s3 › @smithy/core |
@aws-sdk/nested-clients@3.997.49 |
832.2 KB | @rivet-dev/agentos-core › @aws-sdk/client-s3 › @aws-sdk/credential-provider-node › @aws-sdk/credential-provider-ini › @aws-sdk/nested-clients |
minimatch@10.2.6 |
523.6 KB | @rivet-dev/agentos-core › minimatch |
@aws-sdk/core@3.978.4 |
436.1 KB | @rivet-dev/agentos-core › @aws-sdk/client-s3 › @aws-sdk/core |
@smithy/types@4.19.0 |
308.9 KB | @rivet-dev/agentos-core › @aws-sdk/client-s3 › @smithy/types |
bowser@2.14.1 |
252.2 KB | @rivet-dev/agentos-core › @aws-sdk/client-s3 › @aws-sdk/core › bowser |
@aws-sdk/middleware-sdk-s3@3.972.80 |
207.4 KB | @rivet-dev/agentos-core › @aws-sdk/client-s3 › @aws-sdk/middleware-sdk-s3 |
@aws-sdk/checksums@3.1001.4 |
131.6 KB | @rivet-dev/agentos-core › @aws-sdk/client-s3 › @aws-sdk/checksums |
`@rivet-dev/agentos-sandbox` details
| platform | base | this PR | Δ |
|---|---|---|---|
| linux-x64-gnu | 382.4 MB | 363.5 MB | −18.9 MB (−4.9%) |
| linux-arm64-gnu | 380.7 MB | 361.8 MB | −18.9 MB (−5.0%) |
| darwin-arm64 | 352.7 MB | 333.9 MB | −18.9 MB (−5.4%) |
| darwin-x64 | 362.8 MB | 343.9 MB | −18.9 MB (−5.2%) |
| win32-x64 | 245.7 MB | 226.8 MB | −18.9 MB (−7.7%) |
Removed dependencies
| package | size | via |
|---|---|---|
better-sqlite3@12.11.1 |
9.9 MB | @rivet-dev/agentos-sandbox › @rivet-dev/agentos-core › better-sqlite3 |
@aws-sdk/client-s3@3.1154.0 |
3.2 MB | @rivet-dev/agentos-sandbox › @rivet-dev/agentos-core › @aws-sdk/client-s3 |
@smithy/core@3.36.1 |
1.9 MB | @rivet-dev/agentos-sandbox › @rivet-dev/agentos-core › @aws-sdk/client-s3 › @smithy/core |
@aws-sdk/nested-clients@3.997.49 |
832.2 KB | @rivet-dev/agentos-sandbox › @rivet-dev/agentos-core › @aws-sdk/client-s3 › @aws-sdk/credential-provider-node › @aws-sdk/credential-provider-ini › @aws-sdk/nested-clients |
minimatch@10.2.6 |
523.6 KB | @rivet-dev/agentos-sandbox › @rivet-dev/agentos-core › minimatch |
@aws-sdk/core@3.978.4 |
436.1 KB | @rivet-dev/agentos-sandbox › @rivet-dev/agentos-core › @aws-sdk/client-s3 › @aws-sdk/core |
@smithy/types@4.19.0 |
308.9 KB | @rivet-dev/agentos-sandbox › @rivet-dev/agentos-core › @aws-sdk/client-s3 › @smithy/types |
bowser@2.14.1 |
252.2 KB | @rivet-dev/agentos-sandbox › @rivet-dev/agentos-core › @aws-sdk/client-s3 › @aws-sdk/core › bowser |
@aws-sdk/middleware-sdk-s3@3.972.80 |
207.4 KB | @rivet-dev/agentos-sandbox › @rivet-dev/agentos-core › @aws-sdk/client-s3 › @aws-sdk/middleware-sdk-s3 |
@aws-sdk/checksums@3.1001.4 |
131.6 KB | @rivet-dev/agentos-sandbox › @rivet-dev/agentos-core › @aws-sdk/client-s3 › @aws-sdk/checksums |
All 6 packages · linux-x64-gnu
| package (linux-x64-gnu) | @latest |
base | this PR | Δ vs base | packages |
|---|---|---|---|---|---|
@rivet-dev/agentos-core |
458.2 MB | 345.2 MB | 325.9 MB | −19.3 MB (−5.6%) | 10 (−67 (−87.0%)) |
@rivet-dev/agentos-node-pty |
7.6 KB | 18.0 KB | 18.0 KB | 0 | 1 (0) |
@rivet-dev/agentos-posix |
253.6 MB | 253.6 MB | 253.6 MB | 0 | 7 (0) |
@rivet-dev/agentos-runtime-core |
253.6 MB | 253.6 MB | 253.6 MB | 0 | 6 (0) |
@rivet-dev/agentos-sandbox |
495.5 MB | 382.4 MB | 363.5 MB | −18.9 MB (−4.9%) | 85 (−49 (−36.6%)) |
@rivet-dev/agentos-toolchain |
130.8 KB | 141.2 KB | 141.2 KB | 0 | 2 (0) |
🧹 Rust dependencies
Skipped: this PR doesn't change any Rust code or dependencies.
🦀 Binaries
Skipped: this PR doesn't change any Rust code.
⏱ Timing
| job | wall time | slowest step |
|---|---|---|
zizmor |
7s | checkout · 2s |
changes |
24s | checkout · 20s |
footprint |
2m13s | Pack this commit · 35s |
⏭ self-test |
— | skipped |
⏭ native · ${{ matrix.platform }} |
— | skipped |
⏭ hygiene |
— | skipped |
report |
22s | setup-node · 7s |
🔭 Full CI trace for this commit
One OpenTelemetry trace of CI and Pip-Boy for d04f839: every job and step, with the sizes above attached. Run after CI finishes.
pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha d04f8395370af5ebeed5225974f8977c9dc8f894Add --otlp <url> to send it to any OTLP/HTTP collector.
Agent instruction: From a rivet-dev/agentos checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.
eersnington
added a commit
that referenced
this pull request
Oct 21, 2026
Core declared @aws-sdk/client-s3, better-sqlite3, minimatch, and zod-to-json-schema but never imports them; S3 and SQLite live in the sidecar and runtime-core owns its zod-to-json-schema dependency. Also drop better-sqlite3 from onlyBuiltDependencies, since no workspace package installs it anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2064.
@rivet-dev/agentos-coreimports:@aws-sdk/client-s3,better-sqlite3,minimatch, andzod-to-json-schema(runtime-core declares its own).better-sqlite3native addon.pnpm-workspace.yamldrops it fromonlyBuiltDependencies.pnpm-lock.yamlloses about 115 package entries (@aws-sdk/*,@smithy/*, thebetter-sqlite3prebuild chain).@rivet-dev/agentos-sandboxkeepsdockerodeandget-port: its main entry loadssandbox-agent/docker, which imports both.