Repository navigation
fix(execution): keep Python output that has no trailing newline - #2072
Open
eersnington wants to merge 1 commit into
Open
eersnington wants to merge 1 commit into
eersnington wants to merge 1 commit into
Conversation
Contributor
📟 Pip-Boy ·
|
| check | new in this PR | fixed | existing on base |
|---|---|---|---|
| advisories | ✅ 0 | 0 | 25 |
| licenses | ✅ 0 | 0 | 0 |
| sources | ✅ 0 | 0 | 0 |
| bans | ✅ 0 | 0 | 0 |
| unused | ✅ 0 | 0 | 16 |
🦀 Binaries · publish Dockerfiles, --release
Base: main@9413c84, the merge base.
| artifact | npm @latest |
base | this PR | Δ vs base |
|---|---|---|---|---|
agentos-native-sidecar linux-x64-gnu |
143.6 MB | 143.7 MB | 143.7 MB | +104 B (+0.0%) |
⏱ Timing
| job | wall time | slowest step |
|---|---|---|
changes |
27s | checkout · 24s |
zizmor |
11s | checkout · 3s |
hygiene |
1m04s | checkout · 24s |
native · linux-x64-gnu |
10m28s | Build with the publish Dockerfile · 9m50s |
⏭ footprint |
— | skipped |
⏭ self-test |
— | skipped |
report |
22s | setup-node · 7s |
🔭 Full CI trace for this commit
One OpenTelemetry trace of CI and Pip-Boy for dce29ea: every job and step, with the sizes above attached. Run after CI finishes.
pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha dce29eac3c18d3b12d6e8b294f60aff30f67cff4Add --otlp <url> to send it to any OTLP/HTTP collector.
Agent instruction: From a rivet-dev/agentos checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.
The Python runner used Pyodide's line-batched stdout and stderr handlers. They dropped a final partial line and blank lines, and re-added a newline to every write, so print('x', end='') printed nothing.
Write guest stdout and stderr as raw bytes. Silence package-load progress at its source with a loadPackage messageCallback instead of filtering stdout lines.
eersnington
force-pushed
the
fix/python-trailing-output
branch
from
October 21, 2026 15:06
fd006a3 to
dce29ea
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python output without a trailing newline was lost, and blank lines were dropped.
python3 -c …mainprint('a'); print(); print('b', end='')a\na\n\nbsys.stderr.write('err')errwritemode, byte for byte. fix(execution): give Python SystemExit Linux exit codes #2069's main runner flushes Python's own buffers at exit.loadPackagecalls pass a silentmessageCallback. Load errors still reach stderr.