Skip to content

harden: sanitize child_process call in index.js... #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kethinov merged 2 commits into from
Aug 10, 2026
Merged

harden: sanitize child_process call in index.js... #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbbe0fe
fix: javascript.lang.security.detect-child-process.detect-child-proce…
anupamme Aug 9, 2026
32639dd
fix: remove path.basename regression, add shell metacharacter test
anupamme Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
const path = require('path')
const { execSync } = require('child_process')
const { execFileSync } = require('child_process')
const settings = {}
settings.disableRegisterGlobalModel = false

function run (script) {
const scriptPath = path.join(__dirname, script)
try {
const stdout = execSync(`php ${path.join(__dirname, script)}`)
const stdout = execFileSync('php', [scriptPath])
return stdout.toString()
} catch (err) {
throw new Error(`PHP process exited with code ${err.status}`)
Expand All @@ -27,7 +28,7 @@ function runWithData (template, model) {
const jsonModel = JSON.stringify(model, circular())

try {
const stdout = execSync(`php ${path.join(__dirname, '/loader.php')}`, {
const stdout = execFileSync('php', [path.join(__dirname, '/loader.php')], {
input: jsonModel
})
return stdout.toString()
Expand Down
8 changes: 8 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,14 @@ test.serial('Executing a PHP script that has a coding error with `run`', async t
}
})

test.serial('Shell metacharacters in the script path are not executed as shell commands', async t => {
try {
await php.run('./test/lib/templates/selfContainedTest.php; echo pwned')
} catch (e) {
t.true(e.message.includes('PHP process exited with code'))
}
})

test.serial('Executing a PHP script that has a coding error with `runWithData`', async t => {
try {
await php.runWithData('./test/lib/templates/codingError.php')
Expand Down