Repository navigation
chore(deps): eslint config 8.4.1, slop rules, dashboard updates - #151
Merged
Merged
Conversation
Move @rotki/eslint-config to 8.4.1 and @rotki/eslint-plugin to 1.10.0, and space out pnpm-workspace.yaml for the new pnpm/yaml-blank-lines rule.
Turn on the config's slop preset and add eslint-plugin-slop 0.1.3, the version rotki pins. Without the plugin installed the config stops at an interactive install prompt. Rewrite the comments and check-script messages it flagged: em dashes and one comment over the 50 word budget.
Bump vue and @vue/* to 3.5.44, @vitejs/plugin-vue to 6.0.10, vitepress to 2.0.0-alpha.20 with its vite override at 8.3.4, pnpm to 12.14.0, and the eslint, lint-staged, oxc-minify, vitepress-plugin-llms, tsdoc, image-size and markdown-it patches. @types/node stays on 24 to match engines; markdown-it stays on 14 because vitepress types against @types/markdown-it 14. Repin the typos, setup-node, pnpm/action-setup, upload-artifact, download-artifact and codeql actions to their latest tag SHAs. pnpm and codeql-action are newer than the dashboard lists: it lagged the registry, and both releases are past the 7 day window. Vite 8.3 warns that native config loading will reject extensionless relative imports, so the config imports its plugins with .ts extensions and tsconfig allows them.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves to
@rotki/eslint-config8.4.1 and@rotki/eslint-plugin1.10.0, turns on the slop rules, and clears the dependency dashboard formain. Three commits, one per step.eslint config and plugin
cwdwas unset.pnpm/yaml-blank-linesrule wants blank lines between the top-level groups inpnpm-workspace.yaml. The file is regrouped, no setting changes.@rotki/no-template-root-commenthas nothing to report here.Slop rules
slop: trueineslint.config.mjs, pluseslint-plugin-slop0.1.3 (the version rotki pins). The rules only cover JS/TS/Vue, so the markdown pages are untouched.recent-changesmode. That mode exists to skip rotki's backlog, and it diffs againstHEAD~n, which a depth 1 CI checkout does not have.eslint-plugin-slopis an explicit devDependency for the same reason aseslint-plugin-tsdoc: without it the config drops into an interactive install prompt and CI hangs..vitepress/config.mtscut to three lines.Dependency dashboard
minimumReleaseAgewindow. pnpm and codeql-action are newer than the dashboard lists, which lagged the registry. pnpm 12.14.0 has npm provenance.@types/nodestays on 24 to matchengines.node. markdown-it stays on 14: vitepress types against@types/markdown-it ^14..vitepress/config.mtsnow imports its plugins with.ts, andtsconfig.jsonsetsallowImportingTsExtensionsandnoEmit.@vitejs/plugin-vue6.0.8: vitepress depends on it directly.Checked locally
pnpm lint,check:images,check:anchors,check:app-linksandpnpm buildpass.llms.txtand the sitemap, with no console errors.DOCS_VERSION=latestbuild still emitsnoindex, follow, a canonical pointing at stable, assets under/latest/and no sitemap.pnpm devstarts on vitepress alpha.20 with vite 8.3.4 and renders pages with their images.