Skip to content

chore(deps): eslint config 8.4.1, slop rules, dashboard updates - #151

Merged
kelsos merged 3 commits into
rotki:mainfrom
kelsos:chore/eslint-config-8.4.1
Oct 23, 2026
Merged

kelsos merged 3 commits into
rotki:mainfrom
kelsos:chore/eslint-config-8.4.1

Conversation

@kelsos

@kelsos kelsos commented Oct 23, 2026

Copy link
Copy Markdown
Member

Moves to @rotki/eslint-config 8.4.1 and @rotki/eslint-plugin 1.10.0, turns on the slop rules, and clears the dependency dashboard for main. Three commits, one per step.

eslint config and plugin

package from to
@rotki/eslint-config 8.3.0 8.4.1
@rotki/eslint-plugin 1.8.0 1.10.0
  • 8.4.1 rather than 8.4.0: in 8.4.0 the slop inspection silently checked whole files when cwd was unset.
  • The new pnpm/yaml-blank-lines rule wants blank lines between the top-level groups in pnpm-workspace.yaml. The file is regrouped, no setting changes.
  • @rotki/no-template-root-comment has nothing to report here.

Slop rules

slop: true in eslint.config.mjs, plus eslint-plugin-slop 0.1.3 (the version rotki pins). The rules only cover JS/TS/Vue, so the markdown pages are untouched.

  • Full inspection rather than rotki's recent-changes mode. That mode exists to skip rotki's backlog, and it diffs against HEAD~n, which a depth 1 CI checkout does not have.
  • eslint-plugin-slop is an explicit devDependency for the same reason as eslint-plugin-tsdoc: without it the config drops into an interactive install prompt and CI hangs.
  • 10 reports fixed by hand: 9 em dashes in comments and check-script messages, and one 77 word comment in .vitepress/config.mts cut to three lines.

Dependency dashboard

package from to
vitepress 2.0.0-alpha.19 2.0.0-alpha.20
vite (override) 8.2.2 8.3.4
vue, @vue/compiler-sfc, @vue/runtime-dom 3.5.42 3.5.44
@vitejs/plugin-vue 6.0.8 6.0.10
vitepress-plugin-llms 1.13.5 1.14.0
eslint 10.9.1 10.12.0
eslint-plugin-tsdoc 0.5.2 0.5.4
lint-staged 17.4.1 17.6.0
oxc-minify 0.148.0 0.154.0
image-size 2.0.2 2.0.4
markdown-it 14.3.1 14.3.2
@types/node 24.13.3 24.19.2
pnpm 12.1.0 12.14.0
action from to
crate-ci/typos v1.50.0 v1.51.1
actions/setup-node v7.0.0 v7.1.0
pnpm/action-setup v6.0.10 v6.1.0
actions/upload-artifact v7.0.1 v7.0.2
actions/download-artifact v8.0.1 v8.0.2
github/codeql-action v4.37.9 v4.39.0
  • Everything third party is past the 7 day minimumReleaseAge window. pnpm and codeql-action are newer than the dashboard lists, which lagged the registry. pnpm 12.14.0 has npm provenance.
  • Actions stay pinned to commit SHAs, resolved from the release tags.
  • @types/node stays on 24 to match engines.node. markdown-it stays on 14: vitepress types against @types/markdown-it ^14.
  • Vite 8.3 warns that its native config loader will reject extensionless relative imports. .vitepress/config.mts now imports its plugins with .ts, and tsconfig.json sets allowImportingTsExtensions and noEmit.
  • The lockfile still has @vitejs/plugin-vue 6.0.8: vitepress depends on it directly.

Checked locally

  • pnpm lint, check:images, check:anchors, check:app-links and pnpm build pass.
  • Smoke tested the built site: search, the version switcher, code tabs, dark mode, redirects, llms.txt and the sitemap, with no console errors.
  • A DOCS_VERSION=latest build still emits noindex, follow, a canonical pointing at stable, assets under /latest/ and no sitemap.
  • pnpm dev starts on vitepress alpha.20 with vite 8.3.4 and renders pages with their images.

Move @rotki/eslint-config to 8.4.1 and @rotki/eslint-plugin to 1.10.0, and space out pnpm-workspace.yaml for the new pnpm/yaml-blank-lines rule.
Turn on the config's slop preset and add eslint-plugin-slop 0.1.3, the version rotki pins. Without the plugin installed the config stops at an interactive install prompt. Rewrite the comments and check-script messages it flagged: em dashes and one comment over the 50 word budget.
Bump vue and @vue/* to 3.5.44, @vitejs/plugin-vue to 6.0.10, vitepress to 2.0.0-alpha.20 with its vite override at 8.3.4, pnpm to 12.14.0, and the eslint, lint-staged, oxc-minify, vitepress-plugin-llms, tsdoc, image-size and markdown-it patches. @types/node stays on 24 to match engines; markdown-it stays on 14 because vitepress types against @types/markdown-it 14.

Repin the typos, setup-node, pnpm/action-setup, upload-artifact, download-artifact and codeql actions to their latest tag SHAs. pnpm and codeql-action are newer than the dashboard lists: it lagged the registry, and both releases are past the 7 day window.

Vite 8.3 warns that native config loading will reject extensionless relative imports, so the config imports its plugins with .ts extensions and tsconfig allows them.
@kelsos
kelsos merged commit d3e306c into rotki:main Oct 23, 2026
5 checks passed
@kelsos
kelsos deleted the chore/eslint-config-8.4.1 branch October 23, 2026 09:33

This branch was successfully deployed

1 active deployment
github-pages — d3e306c8 Deployed Oct 23, 2026 by kelsos via deploy #235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant