Repository navigation
Conversation
76b11b3 added the HTTP `QUERY` method with `Net::HTTP#query`, `Net::HTTP#request_query` and the `Net::HTTP::Query` request class, but the RBS signature only gained the two methods. Their comments refer to `Net::HTTP::Query`, and `Net::HTTP::Query.new(uri)` is the documented way to build a QUERY request, so declare the class next to the other request classes. The comment is what `rake rbs:annotate` generates for the class. Also cover `#query` and `#request_query` in the RBS tests, mirroring the `#post` / `#request_post` assertions. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#309 (76b11b3) added the HTTP
QUERYmethod:Net::HTTP#query,Net::HTTP#request_queryand theNet::HTTP::Queryrequest class. The RBS signature insig/net-http.rbsgained the two methods but not the class, even though their comments refer toNet::HTTP::QueryandNet::HTTP::Query.new(uri)is the documented way to build a QUERY request.Net::HTTP::Query < Net::HTTPRequestnext to the other request classes. The comment is exactly whatrake rbs:annotategenerates for it; the rest of that task's output (rdoc version noise) is left out.#query/#request_queryassertions totest_sig/test_net_http.rb, mirroring the#post/#request_postones.Verification
bundle exec rake rbs:test: 30 tests, 0 failuresrbs -r net-protocol -r uri -I sig validate: ok🤖 Generated with Claude Code