Repository navigation
bn: treat any truthy odd argument to BN.rand as true - #1121
Merged
Merged
Conversation
OpenSSL::BN.rand compared the optional odd argument with Qtrue, so a truthy value other than true, such as 1, was ignored and the result could be even. Use RTEST() like other optional flags. Fixes ruby#1116
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1116
OpenSSL::BN.rand(bits, fill, odd)comparedoddwithQtrue, so a truthy value other thantrue, such as1, was ignored and the result could be even. It now usesRTEST(), as discussed in the issue.test_randomnow also checks thatBN.rand(8, 1, 1)is odd on each of its 10 draws. Without the change, that assertion fails. The test suite passes locally with OpenSSL 3.6.5 and Ruby 4.0.7.