Skip to content

fix(release): add skip-ovsx opt-out to vscode-promote-prerelease.yml - W-24666922 #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madhur310 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(release): add skip-ovsx opt-out to vscode-promote-prerelease.yml - W-24666922 #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion .github/workflows/vscode-promote-prerelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ name: Promote Nightly to Pre-release
# Requirements - calling repository must have:
# - Nightly tags matching *-nightly.* (e.g., v1.2.3-nightly.20260629)
# - GitHub releases for each nightly tag with VSIX file(s) attached
# - Secrets: IDEE_GH_TOKEN, VSCE_PERSONAL_ACCESS_TOKEN, IDEE_OVSX_PAT
# - Secrets: IDEE_GH_TOKEN, VSCE_PERSONAL_ACCESS_TOKEN
# - IDEE_OVSX_PAT, unless skip-ovsx: 'true' (e.g. the caller publishes Open VSX itself via a
# separate trusted-publishing dispatch, so its workflow_ref matches its stable release path)
#
# Workflow: downloads VSIX → publishes to both marketplaces → creates tracking tag

Expand Down Expand Up @@ -71,6 +73,11 @@ on:
required: false
default: '22.x'
type: string
skip-ovsx:
description: "Skip publishing to Open VSX from this workflow (e.g. because the caller publishes it separately via its own trusted-publishing dispatch)"
required: false
default: "false"
type: string
workflow_dispatch:
inputs:
release-tag:
Expand Down Expand Up @@ -107,6 +114,14 @@ on:
required: false
default: '22.x'
type: string
skip-ovsx:
description: "Skip publishing to Open VSX from this workflow (e.g. because the caller publishes it separately via its own trusted-publishing dispatch)"
required: false
default: "false"
type: choice
options:
- "false"
- "true"

concurrency:
group: promote-prerelease
Expand Down Expand Up @@ -158,6 +173,7 @@ jobs:
EXCLUDE_WEB: ${{ inputs.exclude-web-vsix || 'false' }}
PUBLISH_TOOL: ${{ matrix.publish-tool }}
DRY_RUN: ${{ inputs.dry-run || 'false' }}
SKIP_OVSX: ${{ inputs.skip-ovsx || 'false' }}
VSCE_PERSONAL_ACCESS_TOKEN: ${{ secrets.VSCE_PERSONAL_ACCESS_TOKEN }}
OVSX_PAT: ${{ secrets.IDEE_OVSX_PAT }}
run: |
Expand Down Expand Up @@ -185,6 +201,13 @@ jobs:
TOKEN="$VSCE_PERSONAL_ACCESS_TOKEN"
fi

# Caller publishes Open VSX separately (e.g. via its own trusted-publishing dispatch) --
# skip without even requiring OVSX_PAT to be set.
if [ "$PUBLISH_TOOL" = "ovsx" ] && [ "$SKIP_OVSX" = "true" ]; then
echo "⏭️ Skipping $MARKETPLACE_NAME -- caller publishes it separately (skip-ovsx input)."
exit 0
fi

if [ "$DRY_RUN" != "true" ] && [ -z "$TOKEN" ]; then
echo "::error::Token for $PUBLISH_TOOL is not set"
exit 1
Expand Down
Loading