Repository navigation
Release 0.22.29 - #333
Merged
Merged
Release 0.22.29#333
Conversation
expat 2.9.0 extracted xcslen/xcscmp/xcsncmp into a new translation unit (lib/xcs.c), but Python's build system only compiles the three fixed sources xmlparse.c/xmlrole.c/xmltok.c. When relenv's update_expat() drops the raw 2.9.0 tarball sources into Modules/expat/, xcs.c is never compiled and pyexpat.so fails to link with undefined references to the xcs* symbols on every platform. CPython's own refresh.sh handles this upstream by renaming xcs.c to xcsinc.c and including it from xmlparse.c. Mirror that approach: when the dropped-in tarball ships xcs.c, append #include "xcs.c" to xmlparse.c so the symbols land in the TU Python's build already compiles. The existing entropy-source append is left in place, and the new include is gated on xcs.c's presence so expat < 2.9.0 drop-ins continue to work unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated version bump for Python and bundled dependencies.
This PR will be merged automatically once CI passes, which will
trigger the release workflow.