Repository navigation
Fix limits when numbers are all NaN and we have log scale - #610
Merged
Merged
Conversation
jl-wynen
reviewed
Oct 13, 2026
| if scale not in ('linear', 'log'): | ||
| raise ValueError(f"Unsupported scale: {scale}") | ||
| # We decompose value and unit to avoid operation exceptions when unit=None. | ||
| unit = lims[0].unit |
Member
There was a problem hiding this comment.
Are lims[0] and lims[1] guaranteed to have the same unit? The operations below would fail if that is not the case. (This is not new)
Member
Author
There was a problem hiding this comment.
As long as fix_empty_range is called on the output of find_limits, this is guaranteed, because find_limits takes in only a single Variable, which has the same unit for all the values it holds.
If fix_empty_range suddenly gets used elsewhere, then you could have that error. I can add a check, I guess it's not too expensive (even though everything adds up when you do many small checks on every plot update).
jl-wynen
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following:
It creates a blank figure without raising an error.