Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1277 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 53 53
Lines 8381 8388 +7
=======================================
+ Hits 7662 7669 +7
Misses 719 719
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1271
Following the suggestion in the issue:
_inplace_fix_subset_categorical_obsalready restores the original categories of a filtered table, and it now also restoresuns["<column>_colors"]from the original table. The colors are only copied when the original list has one color per category, so a palette that was already out of sync is left alone.This helper is shared by the joins in
relational_query.py, so the fix applies to every path that goes through it:bounding_box_query/polygon_querywithfilter_table=True, and the join functions.The test reproduces the issue's example: three cells of types A, C and B, with B outside the query box. Categories stay
['A', 'B', 'C'], and the colors are again['red', 'green', 'blue']instead of['red', 'blue'].LLM disclosure (scverse AI policy): Claude Opus 5.5 via Claude Code was used to write this change; the new test and the existing query/operations tests (517 passed) were run locally.