Repository navigation
fix: distinguish legal provider requirements in preview (DEVDB-473) - #757
Merged
sybohy merged 1 commit intoOct 29, 2026
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salto KS's EULA appears as “Other” because the preview recognizes only three exact accessory/subscription messages. Add a Legal category and document/check icon. Allow one source message to produce multiple categories, so Salto Space's EULA plus Seam Bridge displays both Legal and Bridge. Preserve the source explanation and keep unfamiliar text under Other.
This targets the existing design-preview branch behind #755. It does not publish the draft design to production or change Ecosystem/Strapi data.
Source trace: published Strapi providers contain
has_requirements,requirementsanddescription. Ecosystem preserves these ashas_requirements,requirements_mdanddescription_md. Marketingui/apps/marketing/src/services/strapi.tsmapsprovider.description, thenDeviceSystemInfoViewrenders it under About {provider.name}. Device Connectivity comes separately fromdevice_connectivity.report.details. The preview recovers missing legacy provider-report text fromrequirements_md; Other/Legal are presentation aliases, not source schema values.Validation: typecheck, ESLint and formatting passed; 36 focused tests passed, including combined legal/bridge and unknown-text controls. Actual browser checks against the live API passed for all three variants, capability list/matrix, desktop/phone, light/dark and widths 1600/760/390/320. No overflow or JavaScript errors; August accessories and Nuki subscription labels retain their behavior.
https://linear.app/seam/issue/DEVDB-473