Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
ARG VARIANT="24"
ARG VARIANT="24-bookworm"

FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:${VARIANT}
FROM node:24.22.1-bookworm-slim@sha256:55fb5f5a527ea2c5c4a95f963e48ef90aa38c7b346054fdc8ee9957a2b55d205 AS patched-node

FROM mcr.microsoft.com/devcontainers/javascript-node:${VARIANT}

# Patch system and inherited nvm binaries; the floating devcontainer still has Node 24.21.0.
COPY --from=patched-node /usr/local/bin/node /tmp/patched-node
RUN install -m 0755 /tmp/patched-node /usr/local/bin/node \
&& if [ -d /usr/local/share/nvm/versions/node ]; then \
find /usr/local/share/nvm/versions/node -type f -path "*/bin/node" \
-exec install -m 0755 /tmp/patched-node {} \; ; \
fi \
&& rm /tmp/patched-node \
&& test "$(node --version)" = "v24.22.1" \
&& test "$(/usr/local/bin/node --version)" = "v24.22.1"
ENV NODE_VERSION=24.22.1

USER node
WORKDIR /home/node
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"build": {
"dockerfile": "Dockerfile",
"args": {
"VARIANT": "24"
"VARIANT": "24-bookworm"
}
},
"extensions": [
Expand Down
2 changes: 2 additions & 0 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@ runs:
if: inputs.install_dependencies == 'true'
with:
node-version: ${{ inputs.node_version }}
check-latest: true
registry-url: ${{ inputs.registry_url }}
- name: Setup Node.js without cache
uses: actions/setup-node@v7
if: inputs.install_dependencies == 'false'
with:
node-version: ${{ inputs.node_version }}
check-latest: true
registry-url: ${{ inputs.registry_url }}
- name: Install dependencies
if: inputs.install_dependencies == 'true'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ jobs:
uses: actions/setup-node@v7
with:
node-version: ${{ matrix.node }}
check-latest: true
- name: Download artifact
uses: actions/download-artifact@v8
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v7
with:
node-version: 24
check-latest: true
cache: npm
- name: Install dependencies
run: npm ci
Expand Down
Loading