Repository navigation
🐛 Ignore pollInterval and pollDebounce from clients - #750
Merged
Merged
Conversation
|
coverage: 97.852% (+0.001%) from 97.851% — ignore-client-poll-options into main |
Fixes #734 At the moment, `QueryEmitter` prefers `pollInterval` and `pollDebounce` from the query options over the database's own, and those options come straight from the client, so a client can lift the server's poll rate limit: 1. Set `db.pollDebounce = 5000` 2. Subscribe 50 queries with `{pollInterval: 1, pollDebounce: 0}` 3. The database gets ~35,000 polls per second This change strips both keys from client query options in the `Agent`, before `query` middleware runs. Apps that set them from a `Connection` should set them on the database adapter instead, or map their own option onto `context.options` in `query` middleware. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
alecgibson
force-pushed
the
ignore-client-poll-options
branch
from
October 8, 2026 13:37
0641c4f to
bd12640
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation addresses the rate-limit bypass and is adequately tested and documented.
0 open findings
What changed in this PR
Prevents clients from overriding server-controlled query polling limits.
Changes:
- Strips client-provided
pollIntervalandpollDebouncebefore middleware. - Updates polling tests to configure trusted values server-side.
- Documents the new behavior.
| File | Description |
|---|---|
lib/agent.js |
Removes unsafe client polling options. |
test/client/query-subscribe.js |
Tests filtering and server-side configuration. |
docs/middleware/actions.md |
Documents middleware behavior. |
docs/api/connection.md |
Documents ignored client options. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
alecgibson
marked this pull request as ready for review
October 8, 2026 13:51
dawidreedsy
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #734
At the moment,
QueryEmitterpreferspollIntervalandpollDebouncefrom the query options over the database's own, and those options come straight from the client, so a client can lift the server's poll rate limit:db.pollDebounce = 5000{pollInterval: 1, pollDebounce: 0}This change strips both keys from client query options in the
Agent, beforequerymiddleware runs. Apps that set them from aConnectionshould set them on the database adapter instead, or map their own option ontocontext.optionsinquerymiddleware.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com