Repository navigation
Consolidate shiftstack adoption CI fixes - #30
Conversation
a3a26e1 to
8eadd43
Compare
imatza-rh
changed the title
8eadd43 to
d0ba31d
Compare
3acf99e to
856950f
Compare
10c344d to
000ecc4
Compare
imatza-rh
changed the title
000ecc4 to
e9fa78f
Compare
https://issues.redhat.com/browse/OSPRH-34580 Remove the OCPBUGS-67159 VIP workaround, keep openstack_test as a post-adoption verification stage, skip pull-secret extraction when a pull secret is already injected, and include the Swift registry matcher plus Manila empty-catalog guards found during TP validation. Related-Issue: OSPRH-25360 Related-Issue: OSPRH-27365 Signed-off-by: Itay Matza <imatza@redhat.com>
e9fa78f to
05e25d2
Compare
|
Ready for ShiftStack review (undrafted, rebased on current This PR is the ShiftStack-side pin for OSPRH-34580 speculative validation via tp !2579 + ci-framework-jobs !3594. Please review; please do not merge until the speculative 7-stage run shows first SUCCESS of |
Require a defined preexistence check before deleting pull-secret.json so an early release_name failure cannot wipe a pre-populated secret. Co-authored-by: Cursor <cursoragent@cursor.com> Change-Id: Ie19b52766d0d3d6bcc0053caf3310befd57ee57c
Speculative verification (pre-adoption path)On tp !2579 buildset 41613bbd, with
Not covered yet: |
|
@ekuris-redhat @tusharjadhav3302 o/ |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tusharjadhav3302 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@imatza-rh you may want to squash commits to a single commit message for this PR. Thanks! |
3 participants
Consolidated ShiftStack-side adoption CI fixes for OSPRH-34580, kept as one commit and one PR.
Why
The adoption TP can consume only one
cifmw_shiftstack_qa_change_ref, and validation found two small additional ShiftStack-side blockers after the original PR #30 scope. This PR now carries the complete minimal ShiftStack diff needed by the TP; PR #37 and PR #39 are superseded by this branch.Changes
adoption.yamland the IPI install-config template.jobs_definitions/adoption.yamllimited tocleanup,prepare,install,post, andverification.openstack_testonly injobs_definitions/adoption_verification.yaml, after adoption, as a separate post-adoption stage.openstack_testwhenhypervisoris not defined; the test stage itself still runs./home/zuul/pull-secret.jsonis already pre-populated, and preserve pre-populated files during cleanup.namespace.imagetonamespace/imageforjq contains().openstack catalog show manila -f jsonreturns an empty JSON object.Validation
Local checks:
git diff --checkpassed.yamllintpassed on changed YAML files.{}, empty stdout, rc=1 skip; non-empty JSON runs).whenterms after an earlier false term.Full local
pre-commit run --files ...could not complete on this workstation becauseansible-lintsyntax-checks repo playbooks that load encryptedconfigs/secret.yamland no vault secret is available locally. GitHub CI should provide the authoritative ansible-lint result.Keep draft until TP validation is green.