Repository navigation
Keep the MediaInfoLib submodule out of the CodeQL scan [no-new-version] - #9
Merged
Merged
Conversation
The CodeQL build fetched the whole MediaInfoLib submodule, so its sample ASP.NET projects (Web.config) and C# bindings were scanned and raised alerts on third-party code. Sparse-checkout only the stream CSVs the source generator reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178vjPYCurDqWnpvkLsVmZ1
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CodeQL workflow fetched the whole
extern/MediaInfoLibsubmodule, so CodeQL also scanned third-party code that is not part of SharpMediaInfo and raised 4 alerts on MediaInfoLib's sample ASP.NET projects:Project/MSCS2008andProject/MSCS2010/asp_net_web_application/Web.config)The build only needs the stream CSVs read by the source generator, so the submodule is now sparse-checked out to
Source/Resource/Text/Stream. Checked locally on the pinned submodule commit: 1057 files → 29 (the CSVs plus top-level files of the parent folders), 0.configand 0.csfiles left, all 7 CSVs referenced bySharpMediaInfo.csprojpresent.A sparse checkout is used instead of
paths-ignorebecause CodeQL does not reliably applypaths-ignoreto compiled languages withbuild-mode: manual.The 4 open alerts should close on their own after the first analysis of
masterwith this change.Generated by Claude Code