Skip to content

chore(mothership): drop unused worker contract copies - #9228

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/trim-unused-mothership-contracts
Oct 19, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
chore/trim-unused-mothership-contracts

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Drops mothership worker contract copies that nothing in Sim reads, as the companion to the worker change that stops syncing them.

  • apps/sim/lib/mothership/generated/{account,local-files,computer-use}.ts are deleted: none has an importer in apps/, packages/ or scripts/. The desktop computer-use contract Sim does use stays at @sim/desktop-bridge/computer-use (packages/desktop-bridge/src/computer-use.generated.ts).
  • Regenerated from the worker (contracts:sync): generated/protocol.ts loses the unused ActiveStreamConflict interface (the worker never sends that 409), and computer-use.generated.ts loses the unused ComputerUseStatus/ComputerUseApp/ComputerUseWindow type aliases. The schemas behind them are unchanged; Sim's ComputerUseStatus users import the separate interface from @sim/desktop-bridge.
  • knip.jsonc drops the three mirrored-file entries.

Type-only removals and unimported files: no zod schema or wire change, so older workers and self-hosted Sims are unaffected.

Type of Change

  • Other: generated contract cleanup

Testing

The worker's check:contract-sync passes against this branch (no drift, no skip), and check:cli-inventory is in sync. packages/desktop-bridge type-checks; CI runs the full type-check, audits and knip.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Error Error Oct 19, 2026 10:57pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Removes unused generated contract copies and type declarations.

  • Sim no longer keeps three unused worker contract copies.
  • Unused generated type names disappear from the contract files.

No actionable issues found. This review checked source references and related checks; it did not run tests.

Reviews (1) · Last reviewed commit: "chore(mothership): drop unused worker co..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 72855bc into staging Oct 19, 2026
45 of 46 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/trim-unused-mothership-contracts branch October 19, 2026 22:50

This branch had an error being deployed

1 failed deployment
Preview — fe774381 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant