Repository navigation
chore(mothership): drop unused worker contract copies - #9228
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Low impact] The PR appears safe to merge. SummaryRemoves unused generated contract copies and type declarations.
No actionable issues found. This review checked source references and related checks; it did not run tests. Reviews (1) · Last reviewed commit: "chore(mothership): drop unused worker co..." · Reviewed by Greptile |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops mothership worker contract copies that nothing in Sim reads, as the companion to the worker change that stops syncing them.
apps/sim/lib/mothership/generated/{account,local-files,computer-use}.tsare deleted: none has an importer inapps/,packages/orscripts/. The desktop computer-use contract Sim does use stays at@sim/desktop-bridge/computer-use(packages/desktop-bridge/src/computer-use.generated.ts).contracts:sync):generated/protocol.tsloses the unusedActiveStreamConflictinterface (the worker never sends that 409), andcomputer-use.generated.tsloses the unusedComputerUseStatus/ComputerUseApp/ComputerUseWindowtype aliases. The schemas behind them are unchanged; Sim'sComputerUseStatususers import the separate interface from@sim/desktop-bridge.knip.jsoncdrops the three mirrored-file entries.Type-only removals and unimported files: no zod schema or wire change, so older workers and self-hosted Sims are unaffected.
Type of Change
Testing
The worker's
check:contract-syncpasses against this branch (no drift, no skip), andcheck:cli-inventoryis in sync.packages/desktop-bridgetype-checks; CI runs the full type-check, audits and knip.Checklist