Repository navigation
improvement(search): page Slack Real-time Search to fill a Slack-scoped search's limit - #9590
Merged
Merged
Conversation
…ed search's limit
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; both earlier findings are fixed and no new actionable issues remain. SummaryAdds bounded paging for Slack-scoped and native Slack searches. Searches across all sources still read one Slack page.
Reviews (2) · Last reviewed commit: "fix(search): keep earlier Slack pages on..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…age past short pages
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assistant.search.context) returns at most 20 results per call. A Slack-scoped search (sourceslackor a native Slack query) asking for more, e.g.topK: 50, returned one page and a cursor the caller rarely followedType of Change
Testing
Slack RTS pagescases inproviders.test.ts, one per failure mode: native and source-scoped paging, one page for federated searches, stop on no cursor, 3-page cap, file-filled limit, later-page failure keeps earlier pages, first-page failure still throws, non-Slack later-page error, caller cancellation, short pages with a cursor. Removing each guard (targeting, cap, cursor stop, limit stop, later-page catch, abort) turns its test redlib/sim-search/live/suite: 34 files, 364 tests passcheck:comment-hygiene,check:test-patterns,check:utils; full audits and type-check run in CIChecklist
test-auditauthoring gate)