Repository navigation
Add HLL++ bias correction to the dense visitor estimate - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
packages/core/src/hll-bias.tsholds the empirical data for precision 11 from the HyperLogLog++ paper (Heule, Nunkesser, Hall, EDBT 2013):rawEstimateData,biasDataand the linear counting threshold 1,800, with the paper's 6-nearest-neighbour bias lookup.Hll.count()for dense sketches: linear counting up to 1,800, then the raw estimate minus its bias up to 5·m = 10,240, the plain raw estimate above.mergeand thetoBytes/fromBytesformat, so stored sketches keep working.Why
The old count switched from linear counting to the uncorrected raw estimate at 5,120, where the raw estimate runs about 2.5% high. The 5,000 row was the worst in the README table:
Other sizes are unchanged; every size from 1,800 to 6,000 improves.
How it is tested