Skip to content

fix: claim Skill file routes before Markdown negotiation - #662

Merged
harlan-zw merged 1 commit into
mainfrom
fix/skill-reference-markdown-routes
Oct 19, 2026
Merged

harlan-zw merged 1 commit into
mainfrom
fix/skill-reference-markdown-routes

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Found during the SEO recovery check-in.

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Valid Skill reference links ending in .md return 404 because Markdown negotiation claims them before the file guard runs.
Run that guard in Nitro's request hook so file links reach the file viewer.
Ordinary Skill pages keep their Markdown representation.

Skill file request order

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 19, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 19, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

🤖 Harlan Agent Kit Agent assessment of head d8e7ac4.

The Service reported ReserveReached with this head's Review queued. Its exact-head stop returned Stopped before independent review.

The independent review found no defects. Confidence: 95/100. Production behavior awaits deployment smoke checks.
The review covered Nitro request ordering, the module's cached negotiation decision, route boundaries, and the uploaded diagram.

Manual proof outside CI: the built local Worker served all three existing deep-link cases as HTML.
Those cases covered reference.md, LICENSE.txt, and scripts/check_bounding_boxes.py.
Additional HTTP requests returned 200 HTML for the ordinary Skill page and 200 Markdown for its .md representation.
Local D1 contained only public test data for these requests. These checks did not write production D1.

CI passed for this exact head, including build, tests, typecheck, lint, and the harness and declared-Skills checks.
The local full unit suite also passed all 4,041 tests.

The independent assessment leaves the Service Review stopped. Harlan retains the merge decision.

@harlan-zw
harlan-zw merged commit 63b58f1 into main Oct 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant