Repository navigation
Drop workflow DON ID fallback for trigger events - #812
Open
tarcisiozf wants to merge 2 commits into
Open
tarcisiozf wants to merge 2 commits into
tarcisiozf wants to merge 2 commits into
Conversation
tarcisiozf
force-pushed
the
cre-6882-drop-workflow-don-id-fallback
branch
from
October 7, 2026 14:04
827b09a to
09fe7aa
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
HTTP trigger initialization documentation still incorrectly claims that unknown capability DON IDs fall back to workflow DON IDs.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Removes workflow DON ID fallback so trigger events only identify a known sending capability DON.
Changes:
- Adds conditional DON ID labeling helpers for EVM and HTTP triggers.
- Adds unit coverage for known and unknown DON IDs.
- Updates EVM metadata documentation.
| File | Description |
|---|---|
http_trigger/trigger/connector_handler.go |
Removes fallback and conditionally labels HTTP events. |
http_trigger/trigger/don_id_label_test.go |
Tests HTTP DON ID labeling. |
chain_capabilities/evm/trigger/trigger.go |
Removes fallback and conditionally labels EVM events. |
chain_capabilities/evm/trigger/don_id_label_test.go |
Tests EVM DON ID labeling. |
chain_capabilities/evm/main.go |
Documents unknown capability DON behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
tarcisiozf
marked this pull request as ready for review
October 7, 2026 18:41
product-security-plaid-production
Bot
requested review from
george-dorin,
justinkaseman and
silaslenihan
October 7, 2026 18:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines how trigger events are labeled with the DON (Decentralized Oracle Network) ID for both EVM and HTTP trigger plugins. The main improvement is to consistently label events with the sending capability DON ID when it is known, and to leave the label unset when it is unknown, rather than falling back to the consumer workflow's DON ID. This avoids potential mislabeling in multi-DON or legacy node scenarios and ensures more accurate event metadata. The logic for labeling has been centralized into a reusable helper function, and new unit tests have been added to verify this behavior.
Labeling and event metadata improvements:
withCapabilityDonIDhelper function in bothchain_capabilities/evm/trigger/trigger.goandhttp_trigger/trigger/connector_handler.goto consistently label trigger events with the sending capability DON ID only when it is known, leaving the label unset otherwise.Testing improvements:
withCapabilityDonIDfunction in both EVM and HTTP trigger plugins to verify correct labeling behavior when the DON ID is known or unknown.