Skip to content

Remove HTTP trigger multi-execution-ID feature flag - #814

Merged
bolekk merged 2 commits into
mainfrom
remove_http_flag
Oct 7, 2026
Merged

bolekk merged 2 commits into
mainfrom
remove_http_flag

Conversation

@bolekk

@bolekk bolekk commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes the FeatureHTTPTriggerNewExecutionIDsActivePeriod flag now that it's fully rolled out.
  • generateWorkflowExecutionID always uses GenerateExecutionIDWithTriggerIndex; drops the legacy fallback path and the cresettings/limits.RangeLimiter plumbing.
  • Deletes multi_trigger_flag_test.go, which only tested the removed flag behavior.

Deployment Validation

Confirm HTTP trigger execution IDs continue to be generated with trigger index (no spike in execution-ID errors) in prod dashboards after rollout.

🤖 Generated with Claude Code

The FeatureHTTPTriggerNewExecutionIDsActivePeriod flag has been fully
rolled out; always generate execution IDs with the trigger index and
drop the legacy fallback path and its cresettings/limiter plumbing.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@bolekk
bolekk force-pushed the remove_http_flag branch 2 times, most recently from 3bacc06 to cbc1118 Compare October 7, 2026 16:37
Update expected execution ID calculation to use
GenerateExecutionIDWithTriggerIndex (trigger index 0) to match the
removal of the legacy EncodeExecutionID fallback path.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@bolekk
bolekk marked this pull request as ready for review October 7, 2026 16:48
@bolekk
bolekk requested review from a team as code owners October 7, 2026 16:48
@bolekk
bolekk enabled auto-merge October 7, 2026 17:02
@bolekk
bolekk added this pull request to the merge queue Oct 7, 2026
Merged via the queue into main with commit e6f512f Oct 7, 2026
31 of 32 checks passed
@bolekk
bolekk deleted the remove_http_flag branch October 7, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants