Repository navigation
chore: upgrade docker base image - #7402
Open
robertolopezlopez wants to merge 1 commit into
Open
robertolopezlopez wants to merge 1 commit into
robertolopezlopez wants to merge 1 commit into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
robertolopezlopez
force-pushed
the
chore/CLI-1840
branch
13 times, most recently
from
October 27, 2026 11:17
2579c3b to
27ae121
Compare
robertolopezlopez
marked this pull request as ready for review
October 27, 2026 11:35
This comment has been minimized.
This comment has been minimized.
| # install java & scala | ||
| RUN curl -s "https://get.sdkman.io" | bash | ||
| RUN scripts/jvm-install.sh | ||
| ENV PATH=/home/circleci/.sdkman/candidates/gradle/current/bin:/home/circleci/.sdkman/candidates/scala/current/bin:/home/circleci/.sdkman/candidates/sbt/current/bin:/home/circleci/.sdkman/candidates/java/current/bin:$PATH |
Contributor
Author
There was a problem hiding this comment.
change needed to pin maven 3.6.3
| RUN curl -s "https://get.sdkman.io" | bash | ||
| RUN /app/scripts/jvm-install.sh | ||
| ENV PATH=/home/circleci/.sdkman/candidates/scala/current/bin:/home/circleci/.sdkman/candidates/sbt/current/bin:/home/circleci/.sdkman/candidates/java/current/bin:$PATH | ||
| ENV PATH=/home/circleci/.sdkman/candidates/maven/current/bin:/home/circleci/.sdkman/candidates/scala/current/bin:/home/circleci/.sdkman/candidates/sbt/current/bin:/home/circleci/.sdkman/candidates/java/current/bin:$PATH |
Contributor
Author
There was a problem hiding this comment.
change needed to pin maven 3.6.3
Contributor
Author
There was a problem hiding this comment.
changes in this file are required to pin java 17
danskmt
reviewed
Oct 27, 2026
Contributor
There was a problem hiding this comment.
@robertolopezlopez should here also be changed to bookworm?
Contributor
Author
There was a problem hiding this comment.
probably YES!
| # Using debian:bullseye instead of golang:X-bookworm to avoid glibc compatibility issues | ||
| FROM debian:bullseye | ||
| # Use Bookworm for compatibility with pinned OpenSSL/FIPS libraries; verify runtime compatibility before repinning. | ||
| FROM debian:bookworm |
Contributor
There was a problem hiding this comment.
why not trixie? bookworm is already more than 3 years old.
Contributor
Author
There was a problem hiding this comment.
trixie was giving problems in tests, because of its higher glibc version. Bookworm has v2.34 v2.36 and FIPS requires v2.34
Contributor
Author
There was a problem hiding this comment.
I finally managed to solve those Trixie errors. Still, this requires an upgrade of glibc to 2.38 vs. 2.34 in Bookworm... which is more difficult to defend
robertolopezlopez
force-pushed
the
chore/CLI-1840
branch
from
October 27, 2026 16:11
27ae121 to
22bf109
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Where should the reviewer start?
How should this be manually tested?
What's the product update that needs to be communicated to CLI users?
Risk assessment (Low | Medium | High)?
Medium. The change bullseye->bookworm brings a FIX compatibility change. Bookworm requires GLIBC 2.34 and fails on tested GLIBC 2.31. Alpine and static builds are not affected. Still, the E2E pipeline does not show FIPS errors:
Note
Medium Risk
Bookworm raises glibc (2.34) and shifts JVM/Maven/sbt tooling for all Linux Docker CI builds and FIPS-linked images; release pipelines were exercised but runtime compatibility on older distros is the main concern.
Overview
Upgrades CI and test Docker images from Debian Bullseye to Bookworm and rolls CircleCI to freshly built
snyklabs/cli-build-privatetags (20261023-095136on amd64/arm64).The main build image (
.circleci/Dockerfile) and proxy test image (scripts/environments/proxy/Dockerfile) drop aptmavenin favor of SDKMAN:jvm-install.shnow picks Temurin Java 17 more reliably, sets the default JDK, installs Maven 3.6.3, and pins sbt to 1.12.11 (noted as required after Bookworm). Maven is added toPATHin both Dockerfiles.create-build-image.shtightens Go version extraction by anchoring thego_version:grep in.circleci/config.yml.Reviewed by Cursor Bugbot for commit 22bf109. Bugbot is set up for automated code reviews on this repo. Configure here.