Repository navigation
Conversation
fredroy
added
pr: fix
…of the components MatrixLinearSystem builds the matrices of the components in the order of their addresses (maps keyed by pointers): the rounding of the sums of contributions to the same entries changes with the memory layout, from one run to another. - the same scene, its force fields allocated in two opposite orders: the assembled entry is 0 or 1 (three force fields add 1, 1e16 and -1e16 to it); - force fields created in the reverse order of their paths are built in the order of their addresses.
… paths of the components The containers of the components (and of the pairs of mechanical states) of the assembly were ordered by addresses: the order in which the contributions are added to the same entries, hence the rounding of the sums, depended on the memory layout, which changes from one run to another. They are ordered by the paths of the components in the scene graph.
fredroy
force-pushed
the
deterministic_matrix_assembly
branch
from
October 21, 2026 00:56
26c651a to
82d7d3c
Compare
alxbilger
approved these changes
Oct 27, 2026
alxbilger
left a comment
alxbilger
left a comment
Contributor
There was a problem hiding this comment.
The only concern is the loss of performances. Otherwise 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Before, the containers of the components (and of the pairs of mechanical states) of the assembly were ordered by addresses
Now they are ordered by the paths of the components in the scene graph, thus allowing deterministic results
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if