Repository navigation
Refactor profiler component - #643
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The declarative smoke-test configuration still uses the removed profiler schema and needs migration.
1 open finding
What changed in this PR
Centralizes profiling configuration in the OpenTelemetry component provider, replacing the custom YAML parser.
Changes:
- Moves profiler settings into the
swo_profilerprocessor. - Replaces parser and automatic-registration tests with provider tests.
- Removes trace-header and ingestion smoke checks.
| File | Description |
|---|---|
| smoke-tests/src/test/java/com/solarwinds/SmokeTestV2.java | Removes trace assertions. |
| smoke-tests/src/test/java/com/solarwinds/SmokeTest.java | Removes trace assertions. |
| smoke-tests/k6/basic.js | Removes trace-ingestion checks. |
| sdk-config.yaml | Migrates profiler settings. |
| custom/src/test/resources/sdk-config.yaml | Updates valid profiler configuration. |
| custom/src/test/resources/sdk-config-bad.yaml | Updates invalid profiler configuration. |
| custom/src/test/java/com/solarwinds/opentelemetry/extensions/provider/ProfilingSpanProcessorComponentProviderTest.java | Removes old provider-name test. |
| custom/src/test/java/com/solarwinds/opentelemetry/extensions/config/provider/ProfilingSpanProcessorComponentProviderTest.java | Adds provider configuration tests. |
| custom/src/test/java/com/solarwinds/opentelemetry/extensions/config/provider/CustomConfigCustomizerProviderTest.java | Removes automatic-registration tests. |
| custom/src/test/java/com/solarwinds/opentelemetry/extensions/config/parser/yaml/ProfilingSettingsParserTest.java | Removes parser tests. |
| custom/src/main/java/com/solarwinds/opentelemetry/extensions/config/provider/ProfilingSpanProcessorComponentProvider.java | Centralizes parsing and configuration. |
| custom/src/main/java/com/solarwinds/opentelemetry/extensions/config/provider/CustomConfigCustomizerProvider.java | Removes automatic profiler registration. |
| custom/src/main/java/com/solarwinds/opentelemetry/extensions/config/parser/yaml/ProfilingSettingsParser.java | Removes custom parser. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cleverchuk
force-pushed
the
cc/NH-151107
branch
from
October 15, 2026 15:07
fc6bb67 to
c103cc7
Compare
jerrytfleung
left a comment
jerrytfleung
left a comment
There was a problem hiding this comment.
LGTM in general.
We need to use snake_case for the configuration.
| JavaRuntimeVersionChecker.isJdkVersionSupported() | ||
| && profilerSettings.getBoolean("enabled", false); | ||
| int circuitBreakerDurationThreshold = | ||
| profilerSettings.getInt("circuitBreakerDurationThreshold", 100); |
There was a problem hiding this comment.
use snake case to conform the SDK declarative configuration spec.
…unit tests coverage. This done to remove the backend from the test since it's not reliable.
cleverchuk
force-pushed
the
cc/NH-151107
branch
from
October 15, 2026 17:37
c103cc7 to
b59cc6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the profiling configuration handling in the OpenTelemetry SolarWinds extension. It removes the custom YAML parser for profiling settings, consolidates the logic into the
ProfilingSpanProcessorComponentProvider, and updates the configuration and tests to match this new approach. The changes streamline configuration processing, improve maintainability, and ensure that profiling processor configuration is handled consistently via the component provider.Key changes include:
Profiling Configuration Refactor:
Removed the
ProfilingSettingsParserand its associated test, moving all profiling configuration parsing logic intoProfilingSpanProcessorComponentProvider. This centralizes and simplifies how profiling settings are applied. [1] [2] [3] [4] [5]Changed the profiling processor component name from
swo/profilingSpanProcessortoswo_profilerthroughout the codebase and test resources for consistency. [1] [2] [3] [4]Configuration Customization Logic:
CustomConfigCustomizerProviderthat conditionally added the profiling processor based on JDK version, delegating all processor creation and configuration to the component provider. [1] [2] [3] [4] [5]Test Updates:
Added comprehensive tests for
ProfilingSpanProcessorComponentProvider, ensuring correct configuration parsing, error handling, and integration withConfigManager.Updated test resources (
sdk-config.yaml,sdk-config-bad.yaml) and removed or updated tests that depended on the old parser or processor-adding logic. [1] [2] [3] [4] [5]These changes make profiling configuration more robust and easier to maintain by consolidating related logic and ensuring consistent handling across the codebase.
Test services data