Repository navigation
NH-152032 Fix service name calculation in Lambda after upstream fix - #895
Open
tammy-baylis-swi wants to merge 3 commits into
Open
tammy-baylis-swi wants to merge 3 commits into
tammy-baylis-swi wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The prefix check also overrides valid explicitly configured service names.
1 open issue
What changed in this PR
Updates Lambda service-name calculation to recognize upstream OpenTelemetry default names that include an executable suffix.
Changes:
- Expands default-name detection from exact matching to prefix matching.
- Adds a comment describing OpenTelemetry default-name formats.
| File | Description |
|---|---|
| solarwinds_apm/apm_config.py | Updates Lambda service-name fallback detection. |
Review effort: Balanced
tammy-baylis-swi
marked this pull request as ready for review
October 16, 2026 23:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes APM service name calculation in Lambda after upstream fix to follow spec.
Also fixes a CodeQL version hash that dependabot and I missed.