Repository navigation
Allow IS-07 and IS-12 WebSockets to share a port - #525
Open
iibaranov-IG wants to merge 1 commit into
Open
iibaranov-IG wants to merge 1 commit into
iibaranov-IG wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #422
When
events_ws_portandcontrol_protocol_ws_portmatched,make_node_serverrejected the configuration before creating its listeners. The WebSocket endpoints are already route-distinct: IS-07 uses/x-nmos/events/...and IS-12 uses/x-nmos/ncp/v1.0.This change installs one listener for a shared port and dispatches handshake, open, close, and message callbacks by endpoint path. IS-07 and IS-12 retain separate subscription/connection state and message threads. Existing configurations with distinct ports continue to create independent listeners. IS-12 validation now accepts only configured
/x-nmos/ncp/<version>routes, so invalid or conflicting paths are rejected instead of being claimed by the control endpoint.Tests cover same-port, separate-port, IS-07-only, and valid/invalid/conflicting IS-12 routes.
Validation: Debug build and all 189 CTest tests pass on macOS/Apple Silicon.