Repository navigation
e-stepper: the divider is always in view, and no second scroll bar - #156
Merged
Merged
Conversation
In a stacked tab that is short, the horizontal divider (a flex item that could shrink) was squeezed to nothing between the fixed-height program pane and the diagram's least height. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
…der it In a stacked tab the program pane could be dragged taller than the tab, pushing the divider (and the diagram) out of view with nothing to drag back. The pane now leaves room for the divider and the diagram's least height. The divider also sits above the arrows from the program. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
martin-henz
changed the title
…nd it The tab went down to the bottom of the window less a fixed 16px, but the host's panels around it add about 22px more of margin and padding (and 16px of their own), so the tab overflowed its panel and the panel around that: two scroll bars. The room is now worked out from the containers' styles. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
martin-henz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measured in the deployed playground (Python §3, stacked layout, 676px-high window):
flex-shrink: 1; the panes below it were taller than the tab, so it was the one thing squeezed. It is nowflex: 0 0 auto, and sits above the arrows from the program (z-index), so they pass under it.side-content-textpanel scroll. The program pane now leaves room for the divider and for the diagram's least height (80px, was 240px, in a stacked tab) at the tab's current height, so it can no longer be dragged taller than the tab, taking the divider out of view with nothing to drag back.Checked live: with these changes applied to the page, no container around the tab overflows, and the divider is 6px high. Tests: dragging far up/down in a stacked tab keeps the divider and the minimum heights; the room left below the tab follows the containers' styles; the stylesheet keeps the divider unshrinkable and above the arrows.
🤖 Generated with Claude Code