Skip to content

e-stepper: the double arrows jump between breakpoints - #158

Merged
martin-henz merged 6 commits into
mainfrom
e-stepper-breakpoints
Oct 9, 2026
Merged

martin-henz merged 6 commits into
mainfrom
e-stepper-breakpoints

Conversation

@martin-henz

Copy link
Copy Markdown
Member

As in the stepper (chapters 1 and 2 / Python): the double arrows and the a / e keys go to the previous / next breakpoint (a step whose marker has redexNodeType: "DebuggerStatement"), or to the first / last step when there is none. The help text says so.

The e-stepper engine marks breakpoint() statements in source-academy/py-slang#527; until that is released, no step is marked and the arrows behave as before (first / last).

Stacked on #157 (same controls); retargets to main once that is merged.

Tests: the next / previous breakpoint (and the fallbacks), and the buttons and keys on a run with two breakpoints.

🤖 Generated with Claude Code

martin-henz and others added 3 commits October 9, 2026 21:13
Before a run the slider and the step buttons had nothing to act on: a lone
disabled handle and label, and disabled buttons.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Blueprint labelled every s-th value from the first, so with 174 steps the right
end read 163. The slider now runs from 0 (the start) to the number of steps,
and always labels both ends.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The double arrows and the a / e keys go to the previous / next breakpoint()
statement, or to the first / last step when there is none, as in the stepper.
Needs the engine to mark them (py-slang#527).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1bba56d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

martin-henz and others added 2 commits October 9, 2026 21:36
Blueprint's Slider needs max > min; with one state it was 0..0. The slider is
now 0..1 and disabled then.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@martin-henz

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T13:38:56.078235Z 55bc42c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 55bc42cedf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Base automatically changed from e-stepper-controls-after-run to main October 9, 2026 13:41
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@martin-henz
martin-henz merged commit 11900a1 into main Oct 9, 2026
1 check passed
@martin-henz
martin-henz deleted the e-stepper-breakpoints branch October 9, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant