Repository navigation
feat: add a repeatable PARAM keyword for engine flags - #269
Draft
outofcoffee wants to merge 2 commits into
Draft
outofcoffee wants to merge 2 commits into
outofcoffee wants to merge 2 commits into
Conversation
added 2 commits
October 18, 2026 14:46
A PARAM line sets one engine flag, in the engine's own dialect, so a Spinloop can carry its serve options without a preset file. Where both set a flag a PARAM stands over the preset, and the Spinloop's typed instructions stand over a PARAM. For an engine whose model is a flag (llama.cpp's hf/model/hf-file, MTPLX's model) a PARAM with that key names the model in place of MODEL; vLLM takes its model positionally, so a PARAM cannot stand in for it there. Cloud deploy reads PARAMs the way it reads a preset, dropping the cloud-owned settings from them.
outofcoffee
force-pushed
the
feat/param-keyword
branch
from
October 18, 2026 13:49
6b897d4 to
0606d64
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spinloop files can now carry their engine's flags with repeatable
PARAMlines, in place of a preset file.Summary
PARAM key = valueinstruction in Spinloop files; keys are read in the engine's own flag dialect, songlbecomes--n-gpu-layersfor llama.cpp while vLLM's and MTPLX's long-form keys pass through unchangedhf/model/hf-file, MTPLX'smodel— so a Spinloop with no preset file still serves and deploys its model; vLLM takes its model positionally, so a PARAM cannot stand in forMODELtherespinloop cloud deployand a fleet node wake read PARAMs the way they read a preset, dropping the settings the destination owns from them alikeexamples/llamacpp/qwen3.8-27b-mtp, PARAM-based with no preset file, andexamples/vllm/qwen3.8-27b, the first vLLM exampleImplementation details
internal/spinloopgains theParampair and its parse/format;internal/presetgainsDialect.Merge(layers ...)so the PARAM layer is one more layer in the same merge a preset already goes through — the dialect rendering, the owned-flag dropping, and the model-reference handling all fall out of that one changemodelSourceFlags(runner)lists the flags that name the model (llamacpphf-repo/model/hf-file, mtplxmodel, none for vllm), andparamModelis the shared core both the serve and the deploy paths call