Repository navigation
fix(task): check group membership via subquery - #247
Merged
Merged
Conversation
BobAnkh
requested changes
Oct 19, 2026
BobAnkh
approved these changes
Oct 20, 2026
BobAnkh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
POST /taskswithout asuite_uuidreturns 500 ondevwithcolumn reference "id" is ambiguous.internal_submit_taskchecks group membership and bumps the group's task counter in oneUPDATE, joininguser_groupin itsFROM. sea-orm'sexec_with_returningemits an unqualifiedRETURNING "id", …, and with bothgroupanduser_groupin scope Postgres rejects"id"as ambiguous.Membership is now checked with
group.id IN (SELECT group_id FROM user_group WHERE user_id = $1), sogroupis the only table in the statement. The authorization rule, the 404 on a miss and the single-statement atomicity are unchanged. Submissions with a suite were never affected: that path resolves the suite with a separate, column-qualifiedSELECT.