Skip to content

feat(auth): add no browser open flag to login - #1602

Merged
cgoetz-inovex merged 4 commits into
stackitcloud:mainfrom
niri81:feat/login-without-browser-open
Oct 19, 2026
Merged

feat(auth): add no browser open flag to login#1602
cgoetz-inovex merged 4 commits into
stackitcloud:mainfrom
niri81:feat/login-without-browser-open

Conversation

@niri81

@niri81 niri81 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Description

Add an additional option to only print the authorization URL and not open it directly in the standard browser. Especially useful if another browser or an incognito tab need to be used to sign-in with different accounts and bypass automatic SSO login.

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@niri81
feat(auth): add no browser open flag to login
428f564 
Add an additional option to only print the authorization URL and not
open it directly in the standard browser. Especially useful if another
browser or an incognito tab need to be used.
@niri81
niri81 requested a review from a team as a code owner September 14, 2026 09:27
@github-actions

github-actions Bot commented Sep 23, 2026

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale label Sep 23, 2026
@niri81

niri81 commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Review pending, not stale

@Manuelvaas Manuelvaas removed the Stale label Sep 23, 2026
@github-actions

github-actions Bot commented Oct 15, 2026

Copy link
Copy Markdown

This PR was marked as stale after 14 days of inactivity and will be closed after another 14 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale label Oct 15, 2026
@niri81

niri81 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Hi, any update on this?

@rubenhoenle rubenhoenle removed the Stale label Oct 15, 2026
cgoetz-inovex
cgoetz-inovex requested changes Oct 16, 2026
View reviewed changes
Comment thread internal/pkg/auth/user_login.go Outdated
@cgoetz-inovex

cgoetz-inovex commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Hi @niri81,
thanks for your contribution and sorry for the late review. I've tested your branch locally and added a suggestion.
I'll request a 2nd review from our team.
Have a nice day!

@niri81 @cgoetz-inovex
fix(auth): print login url on error verbosity
2e3e685 
Co-authored-by: cgoetz-inovex <carlo.goetz@inovex.de>
@niri81

niri81 commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Hey, thanks for the review. I committed your changes. Will merge main this evening

@cgoetz-inovex
cgoetz-inovex merged commit 7cad135 into stackitcloud:main Oct 19, 2026
5 checks passed
@cgoetz-inovex

cgoetz-inovex commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Just merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marceljk marceljk marceljk approved these changes
@cgoetz-inovex cgoetz-inovex cgoetz-inovex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@niri81 @cgoetz-inovex @marceljk @Fyusel @Manuelvaas @rubenhoenle