Skip to content

fix(renovate): ignore aya dependency so the commit keeps pinned - #2129

Merged
Molter73 merged 1 commit into
mainfrom
mauro/renovate/ignore-aya-dep
Oct 15, 2026
Merged

Molter73 merged 1 commit into
mainfrom
mauro/renovate/ignore-aya-dep

Conversation

@Molter73

@Molter73 Molter73 commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Description

This should prevent mintmaker/renovate from attempting to bump the commit we use for aya.

MintMaker seems to want to update this package, even though our Cargo.toml explicitly states we want a specific commit for it (see #1820 and this slack thread for more context).

Checklist

  • Patch has a change log entry OR does not need one.
  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Run npx --yes --package renovate -- renovate-config-validator and got only the known errors from MintMaker specific configuration:

 INFO: Validating .github/renovate.json5
ERROR: Found errors in configuration
       "file": ".github/renovate.json5",
       "errors": [
         {
           "topic": "Configuration Error",
           "message": "Invalid configuration option: rpmVulnerabilityAutomerge"
         },
         {
           "topic": "Configuration Error",
           "message": "The following managers configured in enabledManagers are not supported: \"rpm-lockfile\""
         }
       ]

Summary by CodeRabbit

  • Chores
    • Automated dependency update suggestions for aya are now skipped until a release with kfunc support is available.

@Molter73
Molter73 requested a review from a team as a code owner October 14, 2026 11:00
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: stackrox/fact/.coderabbit.yml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: c027befe-34c6-4859-9ebb-c2f2f5833d8a
📥 Commits

Reviewing files that changed from the base of the PR and between 661acec and dc28d89.

📒 Files selected for processing: 1
  • .github/renovate.json5

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📝 Walkthrough

The Renovate configuration now ignores the aya dependency. A comment notes that it should be unpinned after a release that supports kfuncs.

Changes: Renovate configuration

Layer / File(s) Summary
Ignore aya updates
.github/renovate.json5
Renovate ignores aya. A comment notes that it should be unpinned after a kfuncs-supporting release.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: msugakov

Merge Risk: ⚪ Minimal · up to dc28d

The configuration now prevents Renovate from updating the pinned aya dependency. No actionable merge-blocking risk is apparent.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely describes the main change: preventing Renovate from updating the pinned aya dependency.
Description check Passed The description includes the change rationale, checklist, and specific testing performed. The unchecked documentation and automated-test items are minor omissions for this configuration-only change.
✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.45%. Comparing base (661acec) to head (dc28d89).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2129   +/-   ##
=======================================
  Coverage   33.45%   33.45%           
=======================================
  Files          22       22           
  Lines        3623     3623           
  Branches     3623     3623           
=======================================
  Hits         1212     1212           
  Misses       2402     2402           
  Partials        9        9           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread .github/renovate.json5
@Molter73
Molter73 requested a review from msugakov October 14, 2026 14:48
@Molter73
Molter73 enabled auto-merge (squash) October 14, 2026 14:49
@msugakov
msugakov disabled auto-merge October 15, 2026 12:56

@msugakov msugakov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled auto-merge but approved. That is to allow you to spot my follow-up question.

Comment thread .github/renovate.json5
@Molter73
Molter73 merged commit ebf9c25 into main Oct 15, 2026
46 of 50 checks passed
@Molter73
Molter73 deleted the mauro/renovate/ignore-aya-dep branch October 15, 2026 13:57
@Molter73

Copy link
Copy Markdown
Member Author

Just as a final bit of context, the latest attempt to update dependencies on the main branch is no longer trying to pull new aya commits, however the workflow is still broken due to the MintMaker image not having the right permissions for the .cargo directory, (see #1820 (comment) updated 4 hours ago).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants