Repository navigation
Conversation
edalzell
force-pushed
the
fix/asset-exists-skip-listing
branch
from
October 16, 2026 02:44
1dbdb61 to
8cfc47c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #15610; merge that first. Until it lands this diff includes its commits.
Asset::exists()answered viacontainer()->files(), which unserializes the whole cached recursive listing.Asset::find()calls it, so resolving one asset reference on the front end loaded the full listing. On a 197k-file S3 container that is an 80 MB cache entry and OOMs a 1 GB worker.exists()now uses the in-memory listing only when this request has already loaded it (AssetContainerContents::isLoaded()), and otherwise does a singledisk()->exists()call (one S3HEAD). CP listings load the listing first, so they keep their zero-extra-IO behaviour. The disk answer is memoized per asset path, sincemeta()callsexists()before its own memo; without that a front-endfind()plus augmenting width/height/size/alt was 16HEADs per asset, now 3.I skipped the suggested meta-cache shortcut:
move()never forgets the old path's meta key, so it would report a moved-away path as existing. A disk check is always right.Closes #15607