Repository navigation
[6.x] Don't fetch Marketplace data during offline license validation - #15653
Merged
Merged
Conversation
When using a license key file, installed addons missing from the file were checked with isCommercial() and existsOnMarketplace(). Since the Marketplace data became lazy, this triggered a request to statamic.com, which can hang on servers without outbound access. Only use Marketplace data the manifest already has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The magic __call method already returns the property without fetching from the Marketplace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rketplace-requests # Conflicts: # tests/Licensing/OutpostTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using offline license validation the Outpost is skipped but installed addons that aren't listed in the key file are checked with
isCommercial()andexistsOnMarketplace(). Since #11948 made Marketplace data lazy, those calls fetch it from statamic.com at runtime. And since #15208 license check-ins also happen after front-end requests and artisan commands.So on servers without outbound access, offline validation ends up making a request that fails or hangs until it times out, including during front-end requests. Released versions have no timeout on Marketplace requests (#15591 adds one).
This PR only uses Marketplace data the addon manifest already has. Addons without it are treated as valid and not listed on the Marketplace, which is the same outcome as a failed request today. Offline validation no longer makes any requests.
Related: #15651