Repository navigation
[6.x] Even out fieldtype icon stroke widths - #15661
Merged
Merged
Conversation
Textarea, List, Collections, Taxonomy and User Groups icons were scaled down or used a wider viewBox, so their strokes drew thinner than 1px. Bump each stroke-width to make up for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
Closes #15652
Most fieldtype icons draw a 1px stroke in a 14×14 viewBox. Five render thinner, because they're either scaled down inside a group or drawn in a wider viewBox with no adjustment to the stroke. Textarea stands out the most.
What this PR Does
Bumps the
stroke-widthon each affected icon to make up for the scaling, so they render at 1px like the rest:I went with the stroke width rather than redrawing the paths into a 14×14 viewBox. It's one attribute per file, the shapes stay exactly as they are, and the diff is easy to check. Redrawing would mean regenerating every path and checking the shapes still match, all to get the same rendered result.
How to Reproduce