Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FieldsetRepository::find()keeps fieldsets in memory, but two kinds of handles never hit the cache:vendor::name. The lookup usesArr::get(), which turns:into.. Sofoo::baris looked up asfoo..bar, but it is stored asfoo::bar.sub/test. The lookup runs before/is normalized to., while the store usessub.test.On a miss, the YAML file is read and parsed again. Blueprints call
find()for everyimport:and everyfield: handle.fieldreference, so blueprints that import addon fieldsets re-parse them on every request. An example would be global set blueprints, which the cascade builds on every frontend request. In a custom addon, a global blueprint importing 12 namespaced fieldsets caused about 13 YAML parses per page request.Changes
find()normalizes the handle, then looks it up as a plain array keysave()stores the saved fieldset in the cachedelete()removes itreset()removes itTests
save(),delete()andreset()Related
#13013 also adds cache updates to
save()/delete(). The two PRs might conflict slightly there.