Repository navigation
[FIXED in 4.5.0] A query that fails after returning rows leaves empty slots at the start of the next query's result #68
Description
DataRow writes result[rows++], and ReadyForQuery resets result but not rows (src/connection.js). rows is only reset in CommandComplete, PortalSuspended and on close. After an ErrorResponse in the middle of a result, the next query on that connection starts at the old index, so its result array begins with empty slots.
The most-reported data bug upstream: porsager#1181, porsager#1119, porsager#795, porsager#1253 (the cleanest reproduction). Proposed fixes: porsager#1254 (one line, with a test that doesn't depend on timing), porsager#1190, porsager#1120.
Fix: reset rows in ReadyForQuery. Test: a query that errors after sending rows, then another query on the same connection.
Activity
chore: release 4.5.0
okomarov commentedon Oct 17, 2026
Shipped in 4.5.0.
[-]A query that fails after returning rows leaves empty slots at the start of the next query's result[/-][+][FIXED in 4.5.0] A query that fails after returning rows leaves empty slots at the start of the next query's result[/+]