Repository navigation
Handle every sendTransaction status in the data, dapp and testing snippets - #168
Merged
stellar-triage-bot[bot] merged 2 commits intoNov 2, 2026
Merged
Conversation
…ppets The data example only acted on PENDING, so DUPLICATE, TRY_AGAIN_LATER and ERROR fell through silently. List the four statuses, retry TRY_AGAIN_LATER with a cap, throw on ERROR with the parsed errorResult, and poll on PENDING or DUPLICATE with pollTransaction. Apply the same branches to the dapp submit helper and the integration-test snippet. Also correct the pollTransaction default (30 attempts, not 5) and the RPC error-handling block, which implied a rejected transaction throws. Add a data eval scenario for the status handling.
|
TRY_AGAIN_LATER after a queue-full rejection bans the transaction hash, so resending it within the retry loop cannot succeed. Say so in the data and dapp snippets and point to a higher fee instead.
Contributor
Author
|
🤖 Automated message from the Stellar Triage Bot. I verified this PR at
|
stellar-triage-bot
Bot
deleted the
issue-agent/166-send-transaction-statuses
branch
November 2, 2026 22:48
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated message from the Stellar Triage Bot.
Closes #166
The data skill's send example acted only on
PENDING. The other three statuses fell through silently. This PR fixes the example and its copies.skills/data/SKILL.md: list the four statuses. RetryTRY_AGAIN_LATERwith a cap, throw onERRORwitherrorResult, and pollPENDINGorDUPLICATEwithpollTransaction. The error-handling block no longer says a rejected transaction throws.skills/dapp/SKILL.md: same branches insubmitSorobanTransaction. ThepollTransactiondefault is 30 attempts, not 5.skills/smart-contracts/testing.md: the integration test now checks the send status and the result.evals/scenarios/data/04-send-transaction-status.json: new scenario.Sources:
src/rpc/api.tsandsrc/rpc/server.tsin js-stellar-sdk v17.4.0 and v16.4.1, and the RPCsendTransactionreference page.