Repository navigation
Correct ledger header units and document the extension field - #2930
Merged
Merged
Conversation
The ledgers page said the fee pool is in lumens. The header stores the fee pool and total coins as integers in stroops. Horizon shows both in XLM. The page now states these units and the base reserve unit. It also adds the header extension field to the field list. Closes #2907
Contributor
Author
|
/triage |
Contributor
stellar-triage-bot
Bot
added
the
bot:ready-to-merge
Contributor
|
🤖 Automated message from the Stellar Triage Bot. Reviewing because @kaankacar asked with /triage. Verified: |
…er-header-units-and-ext
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
ElliotFriend
approved these changes
Nov 2, 2026
3 tasks done
kalepail
added a commit
to stellar-experimental/stellar-raven
that referenced
this pull request
Nov 2, 2026
stellar/stellar-docs#2930 is deployed. Claude Fable 5.1 (high) re-derived the fix live: RETIRE, no residual. Resolution comment posted on stellar/stellar-docs#2907. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kalepail
added a commit
to stellar-experimental/stellar-raven
that referenced
this pull request
Nov 2, 2026
* improvements: mark sd-056 fixed-upstream after the live recheck stellar/stellar-docs#2930 is deployed. Refs #316. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * improvements: retire sd-056 after the distinct review stellar/stellar-docs#2930 is deployed. Claude Fable 5.1 (high) re-derived the fix live: RETIRE, no residual. Resolution comment posted on stellar/stellar-docs#2907. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2907
What
docs/learn/fundamentals/stellar-data-structures/ledgers.mdx:ext).Verification
Stellar-ledger.x(stellar-xdrcurr):totalCoinsandbaseReserveare in stroops.exthas arm0(void) and arm1(LedgerHeaderExtensionV1withflags).feePoolwith no conversion.@stellar/stellar-sdk17.2.1 decoded theheader_xdrof Mainnet ledger 65043333. RawfeePoolandtotalCoinsequal Horizonfee_poolandtotal_coinstimes 10,000,000. RawbaseReserveis 5000000. Theextdiscriminant is0.LEDGER_UPGRADE_FLAGSvote for emergencies.pnpm check:mdx,scripts/check-relative-links.shand an MDX compile pass.Notes
entriesandheaders#2398 touch this page. The PR that merges second needs a rebase.history_ledgerstable callstotal_coinslumens, but the value is in stroops.