Repository navigation
Point JS SDK reference links at the rebuilt SDK docs site - #2986
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
Author
|
🤖 Automated message from the Stellar Triage Bot. Reviewing because this is my own PR for #2969, which @oceans404 called me in on.
Ready to merge. |
ElliotFriend
requested changes
Nov 2, 2026
ElliotFriend
left a comment
Contributor
There was a problem hiding this comment.
All 17 new anchors resolve on the live reference site, thanks. Two things:
- Rebase needed. #2952 and #2933 merged and touched the same lines in
transaction-simulation.mdxandstate-archival.mdx. When resolving, keep this PR's new reference URLs (#2952 kept the old.htmllinks on some of those lines). xdr.mdxlines 144 and 186 still link tojs-stellar-base_src_scval.js.html,global.html#humanizeEvents, andjs-stellar-base_src_events.js.html, which all 404 today. Since this PR is already inxdr.mdx, please fix those too rather than leaving them for #2560.
Contributor
|
/triage |
Contributor
Author
|
🤖 Automated message from the Stellar Triage Bot. Back on this because @ElliotFriend asked with /triage and requested changes.
Ready to merge. Your change request still blocks the merge until you clear it. |
ElliotFriend
approved these changes
Nov 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated message from the Stellar Triage Bot.
Closes #2969
Working this because @oceans404 added bot:take. This PR replaces 23 old
stellar.github.io/js-stellar-sdk/*.htmllinks on 6 pages with links to the rebuilt SDK reference. The old paths return 404.Each new link points at the section heading for that API:
Operation.*,TransactionBuilder,setSorobanData:reference/core-transactions/Contract.call,Contract.getFootprint,Address.fromScAddress,SorobanDataBuilder,authorizeEntry,authorizeInvocation:reference/core-soroban-primitives/Server.prepareTransaction,rpc.assembleTransaction:reference/network-rpc/Client.fromWasmHash:reference/contracts-client/Note:
SorobanDataBuilderis oncore-soroban-primitives, notcore-transactionsas the issue suggests. I checked each anchor against theidattributes on the live pages.Not changed:
xdr.mdxlines 144 and 186. #2560 covers them.Checks:
pnpmneeds approval in this lane, sopnpm format:mdx,pnpm checkandpnpm check:linksdid not run locally. Thechecksjob runs them on this PR.