Skip to content

Point JS SDK reference links at the rebuilt SDK docs site - #2986

Merged
ElliotFriend merged 2 commits into
mainfrom
docs-agent/2969-sdk-reference-links
Nov 3, 2026
Merged

ElliotFriend merged 2 commits into
mainfrom
docs-agent/2969-sdk-reference-links

Conversation

@stellar-triage-bot

Copy link
Copy Markdown
Contributor

🤖 Automated message from the Stellar Triage Bot.

Closes #2969

Working this because @oceans404 added bot:take. This PR replaces 23 old stellar.github.io/js-stellar-sdk/*.html links on 6 pages with links to the rebuilt SDK reference. The old paths return 404.

Each new link points at the section heading for that API:

  • Operation.*, TransactionBuilder, setSorobanData: reference/core-transactions/
  • Contract.call, Contract.getFootprint, Address.fromScAddress, SorobanDataBuilder, authorizeEntry, authorizeInvocation: reference/core-soroban-primitives/
  • Server.prepareTransaction, rpc.assembleTransaction: reference/network-rpc/
  • Client.fromWasmHash: reference/contracts-client/

Note: SorobanDataBuilder is on core-soroban-primitives, not core-transactions as the issue suggests. I checked each anchor against the id attributes on the live pages.

Not changed: xdr.mdx lines 144 and 186. #2560 covers them.

Checks: pnpm needs approval in this lane, so pnpm format:mdx, pnpm check and pnpm check:links did not run locally. The checks job runs them on this PR.

@mintlify

mintlify Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
stellar-docs 🟢 Ready View Preview Nov 3, 2026, 7:25 AM

@stellar-triage-bot

Copy link
Copy Markdown
Contributor Author

🤖 Automated message from the Stellar Triage Bot.

Reviewing because this is my own PR for #2969, which @oceans404 called me in on.

  • Verified: all 17 new anchors exist on the live SDK reference pages. The old paths return 404.
  • The checks job passes. No live preview was available (Mintlify Deployment skipped), so I reviewed from the diff.

Ready to merge.

@ElliotFriend ElliotFriend left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 17 new anchors resolve on the live reference site, thanks. Two things:

  1. Rebase needed. #2952 and #2933 merged and touched the same lines in transaction-simulation.mdx and state-archival.mdx. When resolving, keep this PR's new reference URLs (#2952 kept the old .html links on some of those lines).
  2. xdr.mdx lines 144 and 186 still link to js-stellar-base_src_scval.js.html, global.html#humanizeEvents, and js-stellar-base_src_events.js.html, which all 404 today. Since this PR is already in xdr.mdx, please fix those too rather than leaving them for #2560.

@ElliotFriend

Copy link
Copy Markdown
Contributor

/triage

@stellar-triage-bot

Copy link
Copy Markdown
Contributor Author

🤖 Automated message from the Stellar Triage Bot.

Back on this because @ElliotFriend asked with /triage and requested changes.

  • Merged main. The two conflicts keep this PR's new SDK URLs and main's other link fixes.
  • Fixed the three old links in xdr.mdx lines 144 and 186. scValToNative and humanizeEvents point at their reference sections. extractEvent is internal, so it links to a pinned js-stellar-base commit whose code matches the page snippet.
  • All 19 anchors exist on the live reference pages. checks and the preview pass at the new head.

Ready to merge. Your change request still blocks the merge until you clear it.

@ElliotFriend
ElliotFriend merged commit 1022fac into main Nov 3, 2026
8 checks passed
@ElliotFriend
ElliotFriend deleted the docs-agent/2969-sdk-reference-links branch November 3, 2026 16:16

This branch was successfully deployed

1 active deployment
staging — 26f60bf6 Deployed Nov 3, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:ready-to-merge Bot verified and approved; waiting for a maintainer to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace old JS SDK reference links that now return 404

1 participant