Repository navigation
fix(samlshield): use Bearer auth and configured timeout for async forms - #320
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SamlShieldClient.saml.validate_async()currently fails before sending a request:SamlShieldAsyncClientsets a Bearer Authorization header but inheritsAsyncClient.post_form(), which also passes Basic Auth. aiohttp rejects that combination withValueError: Cannot combine AUTHORIZATION header with AUTH argument or credentials encoded in URL. The async SamlShield timeout is also stored but never forwarded.Add the async counterpart of SamlShield's existing sync
post_formoverride. Send the merged Bearer/form headers without inherited Basic Auth, pass the configuredaiohttp.ClientTimeout, and reuse the existing form-response parser. Ordinary Stytch core clients and their authentication behavior are unchanged. This is hand-maintained SamlShield code, not a generated API method.Three regression cases exercise the public
validate_asyncmethod over real local HTTPS with a short-lived generated certificate, dummy token/form data, and an externally supplied aiohttp session. They verify Bearer/form wire contents, default/configured timeout forwarding, repeated calls and external-session ownership. All three raise the auth-conflict error before the fix and pass afterward. The HTTPS endpoint is a controlled transport fixture; it does not validate SAML and no real Stytch/SamlShield service is called.Validation on Python 3.13:
python -m unittestran 67 tests successfully, with 21 integration tests skipped (46 non-skipped tests); full Black checks (199 files), mypy (199 source files), wheel/sdist builds and diff checks pass. Existing aiohttp BasicAuth deprecation and build metadata warnings remain. Developed with AI assistance and verified locally.