Repository navigation
chore(deps)!: bump substrait packages to 0.104.0 - #309
Merged
nielspardon merged 1 commit intoOct 13, 2026
Merged
Conversation
BREAKING CHANGE: return type derivation expressions now bind `!` tighter than `AND` and `OR` and group chained `? :` conditionals to the right, following spec v0.104.0. User-defined extension YAMLs that relied on the previous grouping derive different return types.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
andrew-coleman
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #280.
Bumps
substrait-protobuf,substrait-extensions, andsubstrait-antlrto spec v0.104.0 (release notes).The standard extension YAMLs are unchanged; the release only adds and prunes function test cases, which this repo does not consume.
The grammar fix does change
substrait.derivation_expression.evaluate, which walks the ANTLR parse tree and so inherits the grammar's precedence. No standard YAML uses prefix!or a chained? :, so only user-defined extension YAMLs can see a difference. New tests pin both behaviors; they fail againstsubstrait-antlr0.103.1.🤖 Generated with AI
BREAKING CHANGE: return type derivation expressions now bind
!tighter thanANDandORand group chained? :conditionals to the right, following spec v0.104.0. User-defined extension YAMLs that relied on the previous grouping derive different return types.